Repository navigation
add(hse): new model and transformation rules - #393
Open
zubeydecivelek wants to merge 2 commits into
Open
zubeydecivelek wants to merge 2 commits into
zubeydecivelek wants to merge 2 commits into
Conversation
1 task done
zubeydecivelek
marked this pull request as draft
March 23, 2026 13:11
zubeydecivelek
force-pushed
the
hse-metadata
branch
from
March 23, 2026 13:15
d18a38f to
843a5ad
Compare
zubeydecivelek
force-pushed
the
hse-metadata
branch
2 times, most recently
from
May 7, 2026 13:35
e77456c to
4f62249
Compare
sakshamarora1
force-pushed
the
hse-metadata
branch
from
October 13, 2026 13:49
4f62249 to
bbb4f7e
Compare
sakshamarora1
marked this pull request as ready for review
October 13, 2026 13:50
sakshamarora1
force-pushed
the
hse-metadata
branch
from
October 16, 2026 12:55
bbb4f7e to
29d0287
Compare
Co-Authored-By: Saksham <sakshamarora1001@gmail.com>
sakshamarora1
force-pushed
the
hse-metadata
branch
from
October 16, 2026 12:58
29d0287 to
f7162cb
Compare
kpsherva
reviewed
Oct 21, 2026
| """Translates collection field.""" | ||
| collection = value.get("a").strip().lower() | ||
| # TODO: should we use these collections? | ||
| if collection not in ["cern", "preprint", "article", "report"]: |
Contributor
There was a problem hiding this comment.
@sakshamarora1 can you check why this is needed?
kpsherva
reviewed
Oct 21, 2026
| def access_note(self, key, value): | ||
| """Translates physical medium field.""" | ||
| access_note = value.get("a").strip() | ||
| if access_note and access_note.lower() not in ["free", "restricted"]: |
Contributor
There was a problem hiding this comment.
could you verify if restricted records are in fact restricted in legacy or the tag is not indicative?
kpsherva
reviewed
Oct 21, 2026
| def note_hse(self, key, value): | ||
| """Translates notes. HSE Articles query is 595__:CERN-HSE.""" | ||
| _note = force_list(value.get("a", "")) | ||
| if _note == ("CERN-HSE",): |
Contributor
There was a problem hiding this comment.
this is quite strange dependency of resource type and note, can you verify why it is done like this? should CERN-HSE be also assigned as report number?
kpsherva
reviewed
Oct 21, 2026
|
|
||
| # Legacy accelerator names remapped to vocabulary ids before lookup | ||
| ACCELERATOR_ALIASES = { | ||
| "cern aa": "antiproton accumulator", |
Contributor
There was a problem hiding this comment.
do we have an entry in the accelerators like this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #639
{"309875": 1023569, "117796": 119661}