Repository navigation
Conversation
| return (source or "").lower() in _ARXIV_SOURCES | ||
|
|
||
|
|
||
| def keep_shared_doi_on_latest(latest_entry, versions): |
There was a problem hiding this comment.
let's discuss this IRL with the team
There was a problem hiding this comment.
more context - this is because of the external DOIs not being displayed on the latest version and if harvester adds a new version, the DOI will not be displayed on the latest
suggested approach: not to create versions for external DOIs, both in migration and harvester
ON HOLD
There was a problem hiding this comment.
discussed:
when we are updating records with external DOIs, we should keep one version only (check how zenodo implements this - the feature is already there, it is a question of setting the permissions correctly)
5b5ade0 to
8b2801f
Compare
TahaKhan998
changed the title
|
can_edit does not use this config, so yes curators can still edit a record after they publish it. They just cannot create a new version when the record has an external DOI, because that goes through can_new_version, which is what this config controls. |
|
Updating files needs a new version. This config blocks new version for records with an external DOI, so a curator cannot add or delete files on those records. They can still edit the metadata. |
5d7e0b6 to
a0200f7
Compare
| Administration(), | ||
| InspireHarvester(), | ||
| SystemProcess(), | ||
| IfExternalDOIRecord( |
There was a problem hiding this comment.
I think it might be more complex than this, see the file modification grace period
There was a problem hiding this comment.
in the scope of this PR I think it will not be?
There was a problem hiding this comment.
depends what this line mean.... anyway my point is, we need to document and know in the case of external DOIs what is the file modification policy:
- do we always allow file modifications?
- is there a file modification grace period and then it is blocked?
this is more essential now that we have blocked newer versions for the external DOIs.
There was a problem hiding this comment.
So what i discovered is that both paths go through RDMDraftFilesComponent on publish. Admins unlock files first, so they don't have modify_locked_files and they hit the 30-day grace period in that component. Owners and curators on external DOI records do get modify_locked_files, so on this line:
that is True for them, which makes not (can_manage_files or can_modify_locked_files) false, so the whole grace-period if is skipped and they can edit files as much as they want on that version.
There was a problem hiding this comment.
didn't we say not to allow owners to modify ? or I got confused
|
combined with Panna's changes, what is now the behaviour? can you guys summarise the different paths ? |
|
My understanding was that this PR will be closed and only mine (#1011) will be applied, since it covers the file modification for both harvester and admins. Only thing I'm not sure about is this line in the config is still needed? |
|
and the behavior in #1011 is
|
a0200f7 to
a54d2bd
Compare
closes #943
same as zenodo, curators shouldn't be able to create a new version of a record that has an external DOI. set RDM_ALLOW_EXTERNAL_DOI_VERSIONING = False.