Repository navigation
fix: stop interrupted scheduled jobs, escape smoke credentials, show the new backup - #61
Merged
Merged
Conversation
…the new backup - run_scheduled.sh starts the job in its own process group and TERMs the group on INT or TERM. Ctrl-C used to reach only the script, so the job kept running. Job output is appended, so the trap's note survives the job's dying words. `just lint` interrupts it to check. - smoke.sh escapes \ and " in the admin password and OTLP token before they go into curl's config, as bootstrap.sh does. - `just backup` lists monitoring-*.tar.gz only: pre-restore-* files sort after them by name, so the last line was the wrong file.
…d backup fixes - run_scheduled.sh gives the job /dev/null as stdin. With job control on, bash stopped doing that, so a job run by hand from a terminal stopped on its first read. - just lint checks that cfg_quote escapes \ and ", and that the backup listing names the new backup rather than a pre-restore snapshot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_scheduled.sh starts the job in its own process group and TERMs the
group on INT or TERM. Ctrl-C used to reach only the script, so the job
kept running. Job output is appended, so the trap's note survives the
job's dying words.
just lintinterrupts it to check.smoke.sh escapes \ and " in the admin password and OTLP token before
they go into curl's config, as bootstrap.sh does.
just backuplists monitoring-.tar.gz only: pre-restore- files sortafter them by name, so the last line was the wrong file.
fix: stop interrupted scheduled jobs, escape smoke credentials, show the new backup
fix: keep scheduled jobs off the caller's stdin and test the smoke and backup fixes
Tests:
install -m 600 .env.example .env && just lint