Repository navigation
Build the MGARD 1.6.0 data-compatibility decoder by default - #264
Merged
JieyangChen7 merged 2 commits intoOct 27, 2026
Merged
Conversation
MGARD_ENABLE_DATA_COMPATIBILITY now defaults to ON. With it OFF, a 1.7 build cannot decompress anything written by MGARD 1.6.x, the previous release: decompress returns DataCompatibilityNotEnabledFailure. Callers that do not check the status cannot tell. ADIOS2's mgard operator, for one, ignores it, so reading 1.6.x data through an OFF build returns zeros with no error. Builds that never read 1.6.x data can still turn the option off. Compressed output is the same with the option ON or OFF. Update the option text, the MGARD-X guide and the 1.7.0 release notes. The "roughly doubles the build time" note is replaced by a neutral one: on one Frontier node (HIP gfx90a + SERIAL + MDR, tests on, -j32) the full build took 7m24s with the decoder instead of 6m42s, and libmgard.so grew from 258 MB to 344 MB. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The build workflow failed in build-MGARD's first step, `sudo apt-get install ...`, with exit code 100, before the code was checked out; the same step passed on master on 2026-10-14. The usual cause is stale package lists: hosted runners ship with the lists from when the image was built, and the mirror drops package versions that have since been superseded. Run `apt-get update` first in every job that installs packages, as GitHub recommends for its hosted runners. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MGARD_ENABLE_DATA_COMPATIBILITY now defaults to ON. With it OFF, a 1.7 build cannot decompress anything written by MGARD 1.6.x, the previous release: decompress returns DataCompatibilityNotEnabledFailure. Callers that do not check the status cannot tell. ADIOS2's mgard operator, for one, ignores it, so reading 1.6.x data through an OFF build returns zeros with no error. Builds that never read 1.6.x data can still turn the option off.
Compressed output is the same with the option ON or OFF.
Update the option text, the MGARD-X guide and the 1.7.0 release notes. The "roughly doubles the build time" note is replaced by a neutral one: on one Frontier node (HIP gfx90a + SERIAL + MDR, tests on, -j32) the full build took 7m24s with the decoder instead of 6m42s, and libmgard.so grew from 258 MB to 344 MB.