Skip to content

Fix legacy Paper-plane editor dialog contrast - #318

Merged
TheWitness merged 1 commit into
Cacti:developfrom
alcatron:fix/paper-plane-editor-contrast-20261018
Oct 17, 2026
Merged

TheWitness merged 1 commit into
Cacti:developfrom
alcatron:fix/paper-plane-editor-contrast-20261018

Conversation

@alcatron

Copy link
Copy Markdown
Contributor

On Cacti 1.2.31 with the Paper-plane theme, standalone editor dialogs have white backgrounds but inherit pale #ccc table text. Labels, checkboxes and help text are difficult to read, including in Map Style.

Add an escaped theme marker to the editor body and scope readable dialog/table/help colours to Paper-plane in the existing legacy stylesheet. Dark section headings retain their theme colours. The stylesheet remains restricted to Cacti releases earlier than 1.2.32; other themes and newer core theme handling are unchanged. Include an issue entry in the 2.0 changelog.

Validation:

  • Reproduced and visually checked an isolated dialog using the installed Cacti 1.2.31 Paper-plane stylesheets: table text changes from #ccc to #333 on white, help text to #555, and section headings remain white on dark.
  • Full PHP suite: 329 tests, 6,401 assertions passed, including curved-comment rendering/configuration tests.
  • PHP syntax, manifest, translation-change and whitespace checks passed.

No live-server deployment is included in this PR.

Copilot AI balanced review requested due to automatic review settings October 17, 2026 16:28
@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are narrowly scoped, preserve the existing version gate, and have no identified blocking issues.

No open issues 🎉

What changed in this PR

Improves standalone editor dialog contrast for Paper-plane on Cacti releases earlier than 1.2.32, leaving other themes and newer releases unchanged.

Changes:

  • Adds an escaped theme marker to the editor body.
  • Applies readable dialog and help-text colours while preserving section headings.
  • Records the fix in the changelog.
File Description
weathermap-cacti-plugin-editor.php Adds the escaped theme marker.
css/​editor-ui-dialog-legacy.css Adds Paper-plane-specific contrast rules.
CHANGELOG.md Documents the legacy contrast fix.

Review effort: Balanced

@TheWitness
TheWitness merged commit e7ee840 into Cacti:develop Oct 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants