Repository navigation
Fix legacy Paper-plane editor dialog contrast - #318
Merged
TheWitness merged 1 commit intoOct 17, 2026
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped, preserve the existing version gate, and have no identified blocking issues.
No open issues 🎉
What changed in this PR
Improves standalone editor dialog contrast for Paper-plane on Cacti releases earlier than 1.2.32, leaving other themes and newer releases unchanged.
Changes:
- Adds an escaped theme marker to the editor body.
- Applies readable dialog and help-text colours while preserving section headings.
- Records the fix in the changelog.
| File | Description |
|---|---|
| weathermap-cacti-plugin-editor.php | Adds the escaped theme marker. |
| css/editor-ui-dialog-legacy.css | Adds Paper-plane-specific contrast rules. |
| CHANGELOG.md | Documents the legacy contrast fix. |
Review effort: Balanced
TheWitness
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



On Cacti 1.2.31 with the Paper-plane theme, standalone editor dialogs have white backgrounds but inherit pale
#ccctable text. Labels, checkboxes and help text are difficult to read, including in Map Style.Add an escaped theme marker to the editor body and scope readable dialog/table/help colours to Paper-plane in the existing legacy stylesheet. Dark section headings retain their theme colours. The stylesheet remains restricted to Cacti releases earlier than 1.2.32; other themes and newer core theme handling are unchanged. Include an issue entry in the 2.0 changelog.
Validation:
No live-server deployment is included in this PR.