Repository navigation
server hands any name it doesn't dispatch to controller_cmd - #54
Conversation
mode is made a core function. is_instrument_command is removed
* camera_mode is removed from the base. the Archon's mode is renamed acfmode and handled in ArchonInterface::controller_cmd, so the server names no mode * selecting an ACF mode section no longer selects an exposure mode, and default_exposure_mode_name is removed. every load leaves no exposure mode selected, and expose is refused until one is selected * the Python mode binding is removed. the example and the module test select SINGLE after power on * CI checks acfmode through controller_cmd, that acfmode leaves the exposure mode alone, and that a load leaves none selected * breaks HISPEC tracking camera: its default_exposure_mode_name override and two-argument set_camera_mode calls no longer compile
|
revised: mode is no longer a core function. the Archon's |
|
I thought I could quickly "un-break" the hispec tracking camera but for now I'm converting this back to draft, until I can show easily what needs to be done. |
|
@mikelangmayr released from draft, ready for review again. hispec-tracking-camera-instrument#1 is the bare minimum to get the tracking camera building against this. The two |
|
Let's go! |
required to meet camera 2.0 design
The server recognizes the core's functions and hands every other name to
controller_cmd.ArchonInterface::controller_cmdisfinaland handles the Archon's own commands and forwards the rest toinstrument_cmd, whose base default logs the unknown command and repliesnot_supported ERROR. Theis_instrument_commandgate is removed, along with the reference instrument's override of it.modeis not a core command.modeis renamedacfmodeand handled byArchonInterface::controller_cmd. It no longer sleects an exposure mode and aloadleaves none selected.The command table in the docs is now generated from both the server and
ArchonInterface::controller_cmd.bobis gone andacfmodeis marked Archon.CI checks
acfmode, agetpreaching the Archon handler throughcontroller_cmd, and an unknown command reaching the baseinstrument_cmd.Breaks HISPEC tracking camera. A hispect-tracking-camera-instrument PR will adapt it and pin the core to this branch.hispec-tracking-camera pr made and waiting for this PR's merge.