Repository navigation
[14/29] Configure editable ZShooter detector alternatives and operating points - #16
Merged
Yashvi-Sharma merged 7 commits intoNov 5, 2026
Conversation
Resolve configured detector references, supply commands to analytical traces and detector headers, and include configured avalanche photon variance. Use 90,000 samples per region for the sparse dark-only Poisson check.
This was referenced Oct 23, 2026
Add a 4096-pixel H4RG K detector mode
…zimager-instrument [28/29] Configure ZImager optics, filters and stochastic detector readouts
Yashvi-Sharma
approved these changes
Nov 5, 2026
Yashvi-Sharma
left a comment
Yashvi-Sharma
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, the detector mode stuff needs to be checked a bit thoroughly, task for later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose editable SPEC and SPEC_ALTDETECT detector packages, including QE, pitch, dark/read inputs, avalanche factor and usable well. Keep the alternative package a design setting. Update the existing physical-test fixtures to resolve these settings rather than assuming old constants.
Part 14/29 of the Caltech review series. Review the diff against
review/xs-13-zshooter-prescription; the final destination isdev_master.Merge after series 13: irdb, series 10: scopesim.
Review focus: ZShooter_v2 detector YAMLs/defaults; tests/test_fidelity_candidates.py.
Validation: 22 repaired detector/trace checks passed; seven unchanged scene checks passed in the initial run. Workspace mode tests verify configured values and unchanged physical trace mapping. The fixture repair changes tests only; 90,000 pixels per region constrain the sparse dark-only Poisson tail.
Source commits/snapshots:
6cb21a3,9884ea7.Use a merge commit to preserve the stack ancestry and pinned commits. After this merges, retarget the next PR in this repository to its default branch. Do not squash/rebase an earlier stack entry without rebuilding its descendants and dependency pins.