Repository navigation
Add a 4096-pixel H4RG K detector mode - #18
Merged
Merged
Conversation
This was referenced Oct 30, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
SPEC_ALTDETECT4K, retaining the alternate package in BLUE/GREEN/RED/YJ/H and replacing K with a 4096 by 4096 H4RG at 10 micron pitch. Detector dimensions and analytical-trace bounds now use the same configured K dimensions; the existing SPEC and H2RG modes explicitly retain 2048 by 2048 K detectors and the physical optical prescription is unchanged.The H4RG package reports
SPEC_ALTDETECT4Kin detector headers. This corrects the initial local configuration that produced 4096-pixel H4RG images labeledSPEC_ALTDETECT.Based on PR #17. Reductions of correctly labeled H4RG frames require zshooter-drp #9. Use a merge commit and retarget to
dev_masterafter #17 merges.Validation: three configured OpticalTrain cases passed for SPEC, H2RG and H4RG, checking mode identity, detector type, dimensions, physical pixel pitch and all eight modeled K orders. The H4RG metadata fix changes neither detector geometry nor noise parameters.