Repository navigation
Syncing forks, pulling from upstream - #9
Closed
Yashvi-Sharma wants to merge 62 commits into
Closed
Yashvi-Sharma wants to merge 62 commits into
Yashvi-Sharma wants to merge 62 commits into
Conversation
Using best-guess values for MICADO, for METIS taken from: #356 (comment) Closes #356, except the LMS extended mode, which is not yet implemented anyway (also set the status to concept for that).
The additional diff comes from stripped whitespace or newlines.
…dded TEL.area default to MICADO MCA mode.
These allow the "full detector array" mode to be a "first-order- configurable", i.e. can be set via `properties`, instead of having to switch the `.include` on the two effects after instantiating the optical train. The latter still works, so this is fully backwards compatible.
…lots in spectroscopy section.
Move notebook tests to separate conftest
Otherwise build hangs...
Comment out NIRCam.yaml to prevent issues with scopesim-service.
Yashvi-Sharma
commented
Oct 15, 2026
Yashvi-Sharma
left a comment
Yashvi-Sharma
left a comment
Collaborator
Author
There was a problem hiding this comment.
LGTM, mostly METIS, MICADO and MOSAIC updates
Those looked like the orthogonal modes in e.g. MICADO, but were never meant to work like that.
Collaborator
Author
|
already merged in other PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.