[ENG-11997] Exclude Unconfirmed Accounts from Email Campaigns - #11878
Open
antkryt wants to merge 1 commit into
Open
[ENG-11997] Exclude Unconfirmed Accounts from Email Campaigns#11878antkryt wants to merge 1 commit into
antkryt wants to merge 1 commit into
Conversation
cslzchen
approved these changes
Aug 26, 2026
cslzchen
left a comment
cslzchen
left a comment
Collaborator
There was a problem hiding this comment.
Looks good but will wait for PO to clarify on "unconfirmed users" before next steps.
cslzchen
requested changes
Aug 26, 2026
cslzchen
left a comment
cslzchen
left a comment
Collaborator
There was a problem hiding this comment.
Update:
- PO confirmed we need to exclude all unconfirmed accounts/users.
- I had a question on null/blank check in my 2nd pass.
Comment on lines
+436
to
+437
| field: "date_confirmed", | ||
| lookup: "isnull", |
Collaborator
There was a problem hiding this comment.
date_confirmed = NonNaiveDateTimeField(db_index=True, null=True, blank=True)
...
@property
def is_confirmed(self):
return bool(self.date_confirmed)Is it possible that date_confirmed is blank instead of null?
Contributor
Author
There was a problem hiding this comment.
date_confirmed is datetime field, postgres timestamptz field cannot be blank ('')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
Add "exclude unconfirmed users" option to notification campaign
Changes
Side Effects
QE Notes
CE Notes
Documentation