fix: 1yr Gains lookback for accurate HL funding projection - #2214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fetch 1 year of Gains history specifically for position reconstruction, separate from the 90-day fee accounting window.
Why
Positions opened >90 days ago had their open events outside the fetch window. With only POSSIZEINCREASE events visible, the reconstruction underestimated notional and duration. Now we fetch from 1 year back, find the actual open timestamps, and still cap
openMstocutoffMsso only carry within the analysis window is projected.Test result (wallet 0x2EF...35a2)
The wallet has positions opened 200+ days ago — none were captured before.