Repository navigation
chore: remove dead code and move dev docs - #47
Merged
Merged
Conversation
Delete the unused proxy builder with unescaped path parameters. Keep request construction in the validated gateway path. Remove unused audit logging and standalone middleware. Retain Limiter.Allow for cross-package integration tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Shreyansh Sancheti <43677304+shreyanshjain7174@users.noreply.github.com>
Move archived build guidance into docs/dev and fix links. Mark the original architecture design as superseded. Describe gateway admission, vault refresh, and receipt ordering. Keep planning files in place because they mention outreach. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Shreyansh Sancheti <43677304+shreyanshjain7174@users.noreply.github.com>
Move planning into docs/dev and update root-relative references. Preserve research citation targets after the directory move. Link planning history from the README. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Shreyansh Sancheti <43677304+shreyanshjain7174@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan
Phase 0, item 8 of the AgentGate scale-out prompt: remove dead code and tidy the docs layout.
What changed
Code (
47707b2). I deleted packages and middleware that nothing imports:internal/proxy(263 lines with tests). It still had the old unescaped, map-order path-param builder fixed in fix(gateway): escape path params and validate before vault access #44, so deleting it also removes a trap.internal/audit(181 lines with tests).auth.Middleware(183 lines with tests).ratelimit.Middleware.go mod tidychanged nothing.Docs (
4b5937b,ca69b6d).agentgate-copilot-instructions.md,agentgate-copilot-prompt.mdandagentgate-agents.mdtodocs/dev/withgit mv..planning/todocs/dev/planning/withgit mv, keeping history, and updated 98 references. Its only "outreach" mentions are about open-source contributors.agentgate-architecture.mdas superseded and pointed it at the README anddocs/.Validation
go build ./...: passedgo vet ./...: passedgo test -race ./...: passedgit diff --check: passed. Changed-doc links and anchors checked.semgrep --config auto --error --quiet ./internal ./cmd: 4 findings, all in files this PR does not change (MCP request handling, 2 cookie sites, JSONL output). They are identical onmain. The earlier per-PR scans covered narrower paths. I'll triage them separately.