Repository navigation
ci(perf): compare against the pull request's base commit and name skipped endpoints - #149
Merged
Merged
Conversation
…pped endpoints The perf job now compares against github.event.pull_request.base.sha rather than the moving base branch, passed through env rather than expanded into the script. perf-compare.sh names each endpoint that failed on the base in a warning and the job summary, because it has no baseline and is left out of the comparison. It fails when the base run produced no report at all.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lewisjared
marked this pull request as ready for review
October 24, 2026 00:04
A base without the synthetic database generator skips every endpoint, which left the job green while comparing nothing. Skipped endpoints are now named in the warnings and job summary like failed ones.
Adds scripts/perf-report.py, which lists each endpoint's base and branch medians and the change, marking those over the threshold, in the job summary and the log. It takes over naming the endpoints that have no baseline. perf-compare.sh writes the report even when the comparison fails, then exits with its status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up the two CodeRabbit threads on #145, which merged before they were addressed.
github.event.pull_request.base.shainstead oforigin/<base branch>, so a base branch that moves during the run cannot skew the comparison. The SHA reaches the shell throughenv, not template expansion.perf-compare.shnames each endpoint that failed or skipped on the base in a warning annotation and the job summary. Before, one generic warning hid which endpoints had no baseline, and a base that skipped every endpoint left the job green with nothing compared. The job stays green for these, because a new endpoint or one the branch fixes is expected to fail on the base.scripts/perf-report.pywrites a table of every endpoint's base and branch medians and the change to the job summary, marking any over the threshold, so the result is readable without opening the log. It runs even when the comparison fails.Tested the report against real pytest-benchmark output with an endpoint that slows down, one only on the branch and one skipped on the base. Also tested it against a pytest JUnit file with a passing test, a failing test, a setup error and a skip, and with no file.