Skip to content

chore: bump pinned valgrind-codspeed to 3.26.0-0codspeed13 - #618

Merged
adriencaccia merged 1 commit into
mainfrom
cod-4123-release-valgrind-codspeed-and-runner
Nov 9, 2026
Merged

adriencaccia merged 1 commit into
mainfrom
cod-4123-release-valgrind-codspeed-and-runner

Conversation

@adriencaccia

Copy link
Copy Markdown
Member

Points the runner at valgrind-codspeed 3.26.0-0codspeed13. Since 0codspeed12, glibc reported the main thread stack as 4 KiB under valgrind at the default ulimit -s, so Python 3.14 failed at startup with a BufferError; the new package reports a size close to RLIMIT_STACK again (CodSpeedHQ/valgrind-codspeed#62).

The 6 hashes match the release's asset digests.

Refs COD-4123, which stays open for the runner v5.7.0 release this unblocks.

Since 0codspeed12, glibc reported the main thread stack as 4 KiB under
valgrind at the default `ulimit -s`, so Python 3.14 failed at startup
with a BufferError. The new package reports a size close to RLIMIT_STACK
again (CodSpeedHQ/valgrind-codspeed#62).

Refs COD-4123
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codspeed

codspeed Bot commented Nov 9, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

2 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 8 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 53 untouched benchmarks
⏩ 6 skipped benchmarks1


Comparing cod-4123-release-valgrind-codspeed-and-runner (4d7aff1) with main (571dea9)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@adriencaccia
adriencaccia marked this pull request as ready for review November 9, 2026 16:47
@greptile-apps

greptile-apps Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Updates the pinned Valgrind package from 3.26.0-0codspeed12 to 3.26.0-0codspeed13 for the Python 3.14 startup fix.

  • The Valgrind runner now uses release 13 on supported Linux hosts.

Reviews (1) · Last reviewed commit: "chore: bump pinned valgrind-codspeed to ..." · Reviewed by Greptile

@adriencaccia
adriencaccia merged commit 21b0cda into main Nov 9, 2026
69 checks passed
@adriencaccia
adriencaccia deleted the cod-4123-release-valgrind-codspeed-and-runner branch November 9, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant