Repository navigation
test: write the example benchmark inside the pytester sandbox - #149
adriencaccia merged 1 commit into
Conversation
tests/examples/test_addition_fixture.py was only input for pytester-based tests, but its name made pytest collect it as a test unless an ignore option kept it out. Those ignores were path-relative, so the wheel tests, which run from another directory, still collected it. Keep its source in an ADDITION_BENCHMARK constant that each test writes into its pytester sandbox with makepyfile, and drop the tests/examples ignores from the pytest config and the cibuildwheel test command. Closes COD-4080 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Low impact] The PR appears safe to merge; no actionable issues were found. SummaryMoves the addition benchmark into an
Reviews (1) · Last reviewed commit: "test: write the example benchmark inside..." · Reviewed by Greptile |
Merging this PR will degrade performance by 6.81%3 warnings, 1 note
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing |
tests/examples/test_addition_fixture.pywas only input for pytester-based tests, but itstest_name made pytest collect it whenever the path-relative--ignoreoptions didn't apply, as in the wheel tests that failed the v5.0.4 release build. Its source now lives in anADDITION_BENCHMARKconstant that each test writes into its pytester sandbox withmakepyfile, so bothtests/examplesignores, including the one from #147, go away.Closes COD-4080