fix: review fast-follows — roadmap closed-milestone truncation + checksum scope (#127) - #128
Merged
Merged
Conversation
…on + checksum scope (#127) - fetch-milestones.mjs: per_page 10→100 for closed milestones — the API returns default (number) order, so per_page=10 silently hid the four newest closures (Phase 14 Self-update, Phase 13 TUI, both 2026-08-19) and the recency sort picked from the wrong set. Verified with token: top-5 closed now the actual newest five. - install.ts ×3: 'attached to every release' → 'every release since v0.12.0' — only 5 of 31 releases carry the per-platform checksum files (v0.11.0, v0.12.0-.2); the broader claim was false for 26 of them. Both from the run's independent review (GO-WITH-NOTES).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #127 — the independent review's two findings: closed milestones now complete (Phase 14/13 visible), checksum claim scoped to reality. Verified: correct top-5 closed set fetched with token; astro check 0 errors; build clean.