Update Firebase sample: .NET 10, current bucket domain, cleanups - #2120
Open
vladimir-pecanac-main wants to merge 1 commit into
Open
Update Firebase sample: .NET 10, current bucket domain, cleanups#2120vladimir-pecanac-main wants to merge 1 commit into
vladimir-pecanac-main wants to merge 1 commit into
Conversation
- Retarget Firebase and Tests to net10.0 and bump packages (Google.Cloud.Firestore 4.4.0, Google.Cloud.Storage.V1 4.15.0, FirebaseAdmin 3.6.0, FirebaseAuthentication.net 4.1.0, JwtBearer/Mvc.Testing 10.0.11, test tooling to current). - BucketName now uses the current default Cloud Storage domain PROJECT_ID.firebasestorage.app; appspot.com only applies to buckets created before September 2024. - Drop the redundant [Required] from ShoeDto.Price: on a non-nullable decimal the model binder cannot tell "absent" from zero, so the attribute implies a guarantee it does not provide. - Replace the bare <label> elements in the shoe list with plain table cells; a label with no for attribute and no associated control is meaningless markup and degrades screen-reader output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refresh of
dotnet-client-libraries/Firebase, the sample for Introduction to Firebase in .NET.net10.0(app and tests) with current packages: Google.Cloud.Firestore 4.4.0, Google.Cloud.Storage.V1 4.15.0, FirebaseAdmin 3.6.0, FirebaseAuthentication.net 4.1.0, Microsoft.AspNetCore.Authentication.JwtBearer / Mvc.Testing 10.0.11, and current test tooling.PROJECT_ID.firebasestorage.app;PROJECT_ID.appspot.comapplies only to buckets created before September 2024.BucketNameis updated accordingly, so a reader who copies it gets a bucket that exists.[Required]onShoeDto.Price. On a non-nullabledecimalthe model binder cannot distinguish "absent" from zero, so the attribute implies a validation guarantee it does not provide.<label>elements in the shoe list with plain table cells. A<label>with noforand no associated control is meaningless markup and degrades screen-reader output.Build and tests on net10.0:
dotnet buildsucceeds with 0 errors;dotnet testpasses 5/5.