OptimisticVsPessimisticLocking: retarget net10.0, fix Optimicstic typo in two action names - #2125
Open
vladimir-pecanac-main wants to merge 1 commit into
Conversation
…o in two action names Retarget the web app and the live-test project from net8.0 to net10.0. Package pins are unchanged: Testcontainers stays at 3.10.0 because 4.x removes IWaitForContainerOS.UntilPortIsAvailable and obsoletes the parameterless ContainerBuilder this sample uses. Correct the misspelling in the two optimistic-locking action names: AssignWorkItemWithAutomaticOptimicsticLockAsync and AssignWorkItemWithManualOptimicsticLockAsync become AssignWorkItemWithAutomaticOptimisticLockAsync and AssignWorkItemWithManualOptimisticLockAsync. Routes are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retargets
dotnet-efcore/OptimisticVsPessimisticLockingtonet10.0and fixes a misspelling in two controller action names.Retarget
OptimisticVsPessimisticLocking.csprojandOptimisticVsPessimisticLocking.LiveTests.csproj:net8.0->net10.0.IWaitForContainerOS.UntilPortIsAvailable, whichProgram.csuses in its wait strategy, and marks the parameterlessContainerBuilder()constructor obsolete.Typo fix
AssignWorkItemWithAutomaticOptimicsticLockAsync->AssignWorkItemWithAutomaticOptimisticLockAsyncAssignWorkItemWithManualOptimicsticLockAsync->AssignWorkItemWithManualOptimisticLockAsyncRoutes (
/workItem/assign-optimistic-row-version,/workItem/assign-manual-optimistic-concurrency-token) are unchanged, so the live tests and the article's request examples are unaffected.Verification
dotnet build OptimisticVsPessimisticLocking.sln -c Releaseon SDK 10.0.302: Build succeeded, 0 errors, 0 CS warnings.NU1901/NU1902/NU1903) on pre-existing transitive packages, surfaced becausenet10.0defaultsNuGetAuditModetoall:SSH.NET 2023.0.0viaTestcontainers 3.10.0, andAzure.Identity 1.10.3/Microsoft.Identity.Client 4.56.0viaMicrosoft.EntityFrameworkCore.SqlServer 8.0.10->Microsoft.Data.SqlClient 5.1.5. No source change in this PR introduces them.dotnet testneeds Docker (Testcontainers starts a real SQL Server container fromProgram.cs), which the machine this was prepared on does not have. This folder is listed in.github/ci-skip-folders.txtfor that same reason, so PR CI does not build or test it either.