Refactor context size warning threshold to use a default constant and support undefined values

Author: robertpiosik

README.md

@@ -12,7 +12,7 @@
   <a href="https://marketplace.visualstudio.com/items?itemName=robertpiosik.gemini-coder"><img src="https://img.shields.io/badge/Install-VS_Code_Marketplace-blue" alt="Get from Visual Studio Code Marketplace" /></a> <a href="https://open-vsx.org/extension/robertpiosik/gemini-coder"><img src="https://img.shields.io/badge/Install-Open_VSX_Registry-a60ee5" alt="Get from Open VSX Registry" /></a> <a href="https://github.com/robertpiosik/CodeWebChat/blob/dev/LICENSE"><img src="https://img.shields.io/badge/License-GPL--3.0-green.svg" alt="GPL-3.0 license" /></a>
 </p>
 
-Code Web Chat is a free and open-source AI coding toolkit. You can use CWC in **VS Code** family of editors (Cursor, Antigravity, VSCodium etc.) for a **fast and cost efficient\*** development experience.
+Code Web Chat is a free and open-source AI coding toolkit. You can use CWC in **VS Code** family of editors (Cursor, Antigravity, VSCodium etc.) for a **fast and cost efficient** AI-assisted development experience.
 
 ✍️ **Construct coding prompts for...**
 

apps/editor/src/constants/values.ts

@@ -1 +1,2 @@
 export const CHECKPOINT_DEFAULT_LIFESPAN = 24
+export const DEFAULT_CONTEXT_SIZE_WARNING_THRESHOLD = 60000

apps/editor/src/views/panel/backend/panel-provider.ts

@@ -65,7 +65,6 @@ import {
   handle_commit_changes,
   handle_accept_commit_message,
   handle_cancel_commit_message,
-  handle_hash_sign_quick_pick,
   handle_proceed_with_commit,
   handle_get_collapsed_states,
   handle_manage_configurations,
@@ -83,7 +82,8 @@ import {
   handle_get_prune_context_instructions_prefix,
   handle_save_prune_context_instructions_prefix,
   handle_open_file_and_select,
-  handle_open_external_url
+  handle_open_external_url,
+  handle_hash_sign_quick_pick
 } from './message-handlers'
 import { SelectionState } from '../types/messages'
 import {
@@ -113,6 +113,7 @@ import { ResponseHistoryItem } from '@shared/types/response-history-item'
 import { CancelTokenSource } from 'axios'
 import { update_last_used_preset_or_group } from './message-handlers/update-last-used-preset-or-group'
 import { dictionary } from '@shared/constants/dictionary'
+import { DEFAULT_CONTEXT_SIZE_WARNING_THRESHOLD } from '@/constants/values'
 
 export class PanelProvider implements vscode.WebviewViewProvider {
   private _webview_view: vscode.WebviewView | undefined
@@ -859,7 +860,10 @@ export class PanelProvider implements vscode.WebviewViewProvider {
   private _send_context_size_warning_threshold() {
     if (!this._webview_view) return
     const config = vscode.workspace.getConfiguration('codeWebChat')
-    const threshold = config.get<number>('contextSizeWarningThreshold', 60000)
+    const threshold = config.get<number>(
+      'contextSizeWarningThreshold',
+      DEFAULT_CONTEXT_SIZE_WARNING_THRESHOLD
+    )
     this.send_message({
       command: 'CONTEXT_SIZE_WARNING_THRESHOLD',
       threshold

apps/editor/src/views/settings/backend/message-handlers/handle-get-context-size-warning-threshold.ts

@@ -1,11 +1,15 @@
 import * as vscode from 'vscode'
 import { SettingsProvider } from '@/views/settings/backend/settings-provider'
+import { DEFAULT_CONTEXT_SIZE_WARNING_THRESHOLD } from '@/constants/values'
 
 export const handle_get_context_size_warning_threshold = async (
   provider: SettingsProvider
 ): Promise<void> => {
   const config = vscode.workspace.getConfiguration('codeWebChat')
-  const threshold = config.get<number>('contextSizeWarningThreshold', 60000)
+  const threshold = config.get<number>(
+    'contextSizeWarningThreshold',
+    DEFAULT_CONTEXT_SIZE_WARNING_THRESHOLD
+  )
   provider.postMessage({
     command: 'CONTEXT_SIZE_WARNING_THRESHOLD',
     threshold

apps/editor/src/views/settings/backend/message-handlers/handle-update-context-size-warning-threshold.ts

@@ -10,7 +10,7 @@ export const handle_update_context_size_warning_threshold = async (
     .getConfiguration('codeWebChat')
     .update(
       'contextSizeWarningThreshold',
-      message.threshold,
+      message.threshold ?? undefined,
       vscode.ConfigurationTarget.Global
     )
 }

apps/editor/src/views/settings/frontend/Home/Home.tsx

@@ -93,7 +93,9 @@ type Props = {
   set_intelligent_update_configs: (configs: ConfigurationForClient[]) => void
   set_prune_context_configs: (configs: ConfigurationForClient[]) => void
   set_commit_messages_configs: (configs: ConfigurationForClient[]) => void
-  on_context_size_warning_threshold_change: (threshold: number) => void
+  on_context_size_warning_threshold_change: (
+    threshold: number | undefined
+  ) => void
   on_commit_instructions_change: (instructions: string) => void
   on_commit_message_auto_accept_after_change: (seconds: number | null) => void
   on_edit_format_instructions_change: (

apps/editor/src/views/settings/frontend/Home/sections/GeneralSection.tsx

@@ -8,6 +8,10 @@ import { Section } from '@ui/components/editor/settings/Section'
 import { TextButton } from '@ui/components/editor/settings/TextButton'
 import { Textarea } from '@ui/components/editor/common/Textarea'
 import { EditFormatInstructions } from '@/views/settings/types/messages'
+import {
+  CHECKPOINT_DEFAULT_LIFESPAN,
+  DEFAULT_CONTEXT_SIZE_WARNING_THRESHOLD
+} from '@/constants/values'
 
 type ClearChecksBehavior = 'ignore-open-editors' | 'uncheck-all'
 
@@ -32,7 +36,9 @@ type Props = {
   on_checkpoint_lifespan_change: (hours: number | undefined) => void
   clear_checks_in_workspace_behavior: ClearChecksBehavior
   edit_format_instructions: EditFormatInstructions
-  on_context_size_warning_threshold_change: (threshold: number) => void
+  on_context_size_warning_threshold_change: (
+    threshold: number | undefined
+  ) => void
   on_clear_checks_in_workspace_behavior_change: (
     value: ClearChecksBehavior
   ) => void
@@ -48,8 +54,8 @@ type Props = {
 export const GeneralSection = forwardRef<HTMLDivElement, Props>(
   (props, ref) => {
     const [context_size_warning_threshold, set_context_size_warning_threshold] =
-      useState('')
-    const [checkpoint_lifespan_str, set_checkpoint_lifespan_str] = useState('')
+      useState<number>()
+    const [checkpoint_lifespan, set_checkpoint_lifespan] = useState<number>()
     const [gemini_user_id_str, set_gemini_user_id_str] = useState('')
     const [ai_studio_user_id_str, set_ai_studio_user_id_str] = useState('')
     const [instructions, set_instructions] = useState<EditFormatInstructions>({
@@ -66,13 +72,11 @@ export const GeneralSection = forwardRef<HTMLDivElement, Props>(
     })
 
     useEffect(() => {
-      set_context_size_warning_threshold(
-        String(props.context_size_warning_threshold)
-      )
+      set_context_size_warning_threshold(props.context_size_warning_threshold)
     }, [props.context_size_warning_threshold])
 
     useEffect(() => {
-      set_checkpoint_lifespan_str(String(props.checkpoint_lifespan))
+      set_checkpoint_lifespan(props.checkpoint_lifespan)
     }, [props.checkpoint_lifespan])
 
     useEffect(() => {
@@ -99,18 +103,27 @@ export const GeneralSection = forwardRef<HTMLDivElement, Props>(
     }, [props.edit_format_instructions])
 
     const handle_context_size_warning_threshold_blur = () => {
-      const num_threshold = parseInt(context_size_warning_threshold, 10)
-      if (!isNaN(num_threshold) && num_threshold >= 0) {
-        props.on_context_size_warning_threshold_change(num_threshold)
+      if (
+        context_size_warning_threshold &&
+        context_size_warning_threshold > 0
+      ) {
+        props.on_context_size_warning_threshold_change(
+          context_size_warning_threshold
+        )
+      } else {
+        props.on_context_size_warning_threshold_change(undefined)
+        set_context_size_warning_threshold(
+          DEFAULT_CONTEXT_SIZE_WARNING_THRESHOLD
+        )
       }
     }
 
     const handle_checkpoint_lifespan_blur = () => {
-      const num_hours = parseInt(checkpoint_lifespan_str, 10)
-      if (!isNaN(num_hours) && num_hours > 0) {
-        props.on_checkpoint_lifespan_change(num_hours)
+      if (checkpoint_lifespan && checkpoint_lifespan > 0) {
+        props.on_checkpoint_lifespan_change(checkpoint_lifespan)
       } else {
         props.on_checkpoint_lifespan_change(undefined)
+        set_checkpoint_lifespan(CHECKPOINT_DEFAULT_LIFESPAN)
       }
     }
 
@@ -181,8 +194,12 @@ export const GeneralSection = forwardRef<HTMLDivElement, Props>(
             slot_right={
               <Input
                 type="number"
-                value={context_size_warning_threshold}
-                on_change={set_context_size_warning_threshold}
+                value={context_size_warning_threshold?.toString() ?? ''}
+                on_change={(val) =>
+                  set_context_size_warning_threshold(
+                    val == '' ? undefined : parseInt(val, 10)
+                  )
+                }
                 on_blur={handle_context_size_warning_threshold_blur}
                 max_width={100}
               />
@@ -239,8 +256,12 @@ export const GeneralSection = forwardRef<HTMLDivElement, Props>(
             slot_right={
               <Input
                 type="number"
-                value={checkpoint_lifespan_str}
-                on_change={set_checkpoint_lifespan_str}
+                value={checkpoint_lifespan?.toString() || ''}
+                on_change={(val) =>
+                  set_checkpoint_lifespan(
+                    val == '' ? undefined : parseInt(val, 10)
+                  )
+                }
                 on_blur={handle_checkpoint_lifespan_blur}
                 max_width={100}
               />

apps/editor/src/views/settings/frontend/hooks/use-settings.ts

@@ -276,10 +276,12 @@ export const use_settings = (vscode: any) => {
   const handle_open_allow_patterns_settings = () =>
     post_message(vscode, { command: 'OPEN_ALLOW_PATTERNS_SETTINGS' })
 
-  const handle_context_size_warning_threshold_change = (threshold: number) =>
+  const handle_context_size_warning_threshold_change = (
+    threshold: number | undefined
+  ) =>
     post_message(vscode, {
       command: 'UPDATE_CONTEXT_SIZE_WARNING_THRESHOLD',
-      threshold
+      threshold: threshold ?? null
     })
 
   const handle_edit_format_instructions_change = (

apps/editor/src/views/settings/types/messages.ts

@@ -200,7 +200,7 @@ export interface GetContextSizeWarningThresholdMessage {
 
 export interface UpdateContextSizeWarningThresholdMessage {
   command: 'UPDATE_CONTEXT_SIZE_WARNING_THRESHOLD'
-  threshold: number
+  threshold: number | null
 }
 
 export interface GetAreAutomaticCheckpointsDisabledMessage {