Skip to content

Commit 6a96c30

Browse files
robertpiosikrobertpiosik
committed
Standardize API configuration quick pick titles and placeholders using model selection translations
- `apps/editor/src/utils/show-configurations-quick-pick.ts` should show title/placeholder per type: api: Models, web: Chatbots - `apps/editor/src/views/settings/backend/message-handlers/handle-select-default-api-configuration.ts` should use title/placeholder about model - model/choose model should be in `apps/editor/src/i18n/translations/common.ts` └── apps └── editor └── src ├── commands │ ├── code-at-cursor-command │ │ └── utils │ │ ├── get-code-at-cursor-config.ts │ │ └── perform-code-at-cursor.ts │ └── generate-commit-message-commands │ ├── actions │ │ └── run-generate-action.ts │ └── utils │ └── get-commit-message-config.ts ├── features │ └── search-files │ ├── search-modes │ │ └── perform-intelligent-search-mode.ts │ └── utils │ └── prompt-for-config.ts ├── i18n │ ├── index.ts │ └── translations │ ├── common.ts │ └── views │ ├── index.ts │ └── shared │ ├── actions │ │ ├── api │ │ │ ├── common.ts │ │ │ ├── create │ │ │ │ ├── create.ts │ │ │ │ ├── index.ts │ │ │ │ └── interactions │ │ │ │ ├── index.ts │ │ │ │ ├── initial-select-model.ts │ │ │ │ ├── initial-select-provider.ts │ │ │ │ └── verify-model.ts │ │ │ ├── delete.ts │ │ │ ├── index.ts │ │ │ ├── pick-extended-provider.ts │ │ │ ├── pick-reasoning-effort.ts │ │ │ ├── update │ │ │ │ └── interactions │ │ │ │ ├── edit-model-for-api-config.ts │ │ │ │ └── edit-reasoning-effort-for-api-config.ts │ │ │ └── upsert-provider.ts │ │ ├── index.ts │ │ └── web │ │ ├── index.ts │ │ └── pick-chatbot.ts │ └── index.ts ├── utils │ └── show-configurations-quick-pick.ts └── views ├── prompt │ └── backend │ └── message-handlers │ ├── handle-autofill.ts │ ├── handle-make-api-call.ts │ ├── handle-patch-repair.ts │ ├── handle-voice-input.ts │ └── utils │ └── patch-repair-utils.ts ├── settings │ └── backend │ └── message-handlers │ └── handle-select-default-api-configuration.ts └── shared └── actions └── api ├── create │ └── interactions │ └── initial-select-model.ts └── update └── interactions └── edit-model-for-api-config.ts
1 parent c06b813 commit 6a96c30

9 files changed

Lines changed: 52 additions & 104 deletions

File tree

‎apps/editor/src/commands/code-at-cursor-command/utils/get-code-at-cursor-config.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,7 @@ export const get_code_at_cursor_api_configuration = async (params: {
5050
const result = await show_configurations_quick_pick({
5151
items: code_at_cursor_api_configurations,
5252
type: 'api',
53-
last_selected_id,
54-
placeholder: t('command.code-at-cursor.config.placeholder')
53+
last_selected_id
5554
})
5655

5756
if (!result || result === 'back') {

‎apps/editor/src/commands/generate-commit-message-commands/utils/get-commit-message-config.ts‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,10 @@ export const get_commit_message_api_configuration = async (params: {
5656
LAST_USED_COMMIT_MESSAGES_CONFIG_ID_STATE_KEY
5757
)
5858

59-
const placeholder = t('common.config.placeholder')
60-
6159
const result = await show_configurations_quick_pick({
6260
items: api_configurations,
6361
type: 'api',
6462
last_selected_id,
65-
placeholder,
6663
show_back_button
6764
})
6865

‎apps/editor/src/i18n/translations/common.ts‎

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -215,42 +215,6 @@ export const translations = {
215215
hu: 'egyéb konfigurációk',
216216
bg: 'други конфигурации'
217217
},
218-
'common.config.title': {
219-
en: 'Configurations',
220-
pl: 'Konfiguracje',
221-
'zh-cn': '配置',
222-
ja: '設定',
223-
'zh-tw': '設定',
224-
de: 'Konfigurationen',
225-
es: 'Configuraciones',
226-
fr: 'Configurations',
227-
'pt-br': 'Configurações',
228-
ru: 'Конфигурации',
229-
ko: '구성',
230-
it: 'Configurazioni',
231-
tr: 'Yapılandırmalar',
232-
cs: 'Konfigurace',
233-
hu: 'Konfigurációk',
234-
bg: 'Конфигурации'
235-
},
236-
'common.config.placeholder': {
237-
en: 'Select configuration',
238-
pl: 'Wybierz konfigurację',
239-
'zh-cn': '选择配置',
240-
ja: '設定を選択',
241-
'zh-tw': '選擇設定',
242-
de: 'Konfiguration auswählen',
243-
es: 'Seleccionar configuración',
244-
fr: 'Sélectionner une configuration',
245-
'pt-br': 'Selecionar configuração',
246-
ru: 'Выберите конфигурацию',
247-
ko: '구성 선택',
248-
it: 'Seleziona configurazione',
249-
tr: 'Yapılandırma seç',
250-
cs: 'Vyberte konfiguraci',
251-
hu: 'Válasszon konfigurációt',
252-
bg: 'Изберете конфигурация'
253-
},
254218
'common.totalling-tokens': {
255219
en: 'totalling {tokens} tokens',
256220
pl: 'łącznie {tokens} tokenów',
@@ -666,6 +630,42 @@ export const translations = {
666630
hu: 'Prompt másolása',
667631
bg: 'Копиране на промпт'
668632
},
633+
'common.select-model.title': {
634+
en: 'Models',
635+
pl: 'Modele',
636+
'zh-cn': '模型',
637+
ja: 'モデル',
638+
'zh-tw': '模型',
639+
de: 'Modelle',
640+
es: 'Modelos',
641+
fr: 'Modèles',
642+
'pt-br': 'Modelos',
643+
ru: 'Модели',
644+
ko: '모델',
645+
it: 'Modelli',
646+
tr: 'Modeller',
647+
cs: 'Modely',
648+
hu: 'Modellek',
649+
bg: 'Модели'
650+
},
651+
'common.select-model.placeholder': {
652+
en: 'Choose a model',
653+
pl: 'Wybierz model',
654+
'zh-cn': '选择一个模型',
655+
ja: 'モデルを選択',
656+
'zh-tw': '選擇一個模型',
657+
de: 'Wähle ein Modell',
658+
es: 'Elige un modelo',
659+
fr: 'Choisissez un modèle',
660+
'pt-br': 'Escolha um modelo',
661+
ru: 'Выберите модель',
662+
ko: '모델 선택',
663+
it: 'Scegli un modello',
664+
tr: 'Bir model seçin',
665+
cs: 'Vyberte model',
666+
hu: 'Válasszon egy modellt',
667+
bg: 'Изберете модел'
668+
},
669669
'common.info.continue-in-browser': {
670670
en: 'Continue in the browser.',
671671
pl: 'Kontynuuj w przeglądarce.',

‎apps/editor/src/i18n/translations/views/shared/actions/api/create/interactions/initial-select-model.ts‎

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,4 @@
11
export const translations = {
2-
'views.shared.actions.api.create.interactions.initial-select-model.title': {
3-
en: 'Models',
4-
pl: 'Modele',
5-
'zh-cn': '模型',
6-
ja: 'モデル',
7-
'zh-tw': '模型',
8-
de: 'Modelle',
9-
es: 'Modelos',
10-
fr: 'Modèles',
11-
'pt-br': 'Modelos',
12-
ru: 'Модели',
13-
ko: '모델',
14-
it: 'Modelli',
15-
tr: 'Modeller',
16-
cs: 'Modely',
17-
hu: 'Modellek',
18-
bg: 'Модели'
19-
},
20-
'views.shared.actions.api.create.interactions.initial-select-model.placeholder':
21-
{
22-
en: 'Choose a model',
23-
pl: 'Wybierz model',
24-
'zh-cn': '选择一个模型',
25-
ja: 'モデルを選択',
26-
'zh-tw': '選擇一個模型',
27-
de: 'Wähle ein Modell',
28-
es: 'Elige un modelo',
29-
fr: 'Choisissez un modèle',
30-
'pt-br': 'Escolha um modelo',
31-
ru: 'Выберите модель',
32-
ko: '모델 선택',
33-
it: 'Scegli un modello',
34-
tr: 'Bir model seçin',
35-
cs: 'Vyberte model',
36-
hu: 'Válasszon egy modellt',
37-
bg: 'Изберете модел'
38-
},
392
'views.shared.actions.api.create.interactions.initial-select-model.prompt': {
403
en: 'Enter a model name (ID)',
414
pl: 'Wprowadź nazwę modelu (ID)',

‎apps/editor/src/utils/show-configurations-quick-pick.ts‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,12 @@ export const show_configurations_quick_pick = async <T>(
7474
items: configurations,
7575
type,
7676
last_selected_id,
77-
title = t('common.config.title'),
78-
placeholder = 'Select a configuration',
77+
title = type === 'api'
78+
? t('common.select-model.title')
79+
: t('views.shared.actions.web.pick-chatbot.title'),
80+
placeholder = type === 'api'
81+
? t('common.select-model.placeholder')
82+
: t('views.shared.actions.web.pick-chatbot.placeholder'),
7983
show_back_button = false
8084
} = options
8185

‎apps/editor/src/views/prompt/backend/message-handlers/utils/patch-repair-utils.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,7 @@ export const get_patch_repair_config = async (params: {
5454
const result = await show_configurations_quick_pick({
5555
items: patch_repair_api_configurations,
5656
type: 'api',
57-
last_selected_id,
58-
placeholder: t('common.config.placeholder')
57+
last_selected_id
5958
})
6059

6160
if (!result || result === 'back') {

‎apps/editor/src/views/settings/backend/message-handlers/handle-select-default-api-configuration.ts‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,8 @@ export const handle_select_default_api_configuration = async (
4343
>()
4444

4545
quick_pick.items = items
46-
quick_pick.title = t('common.config.title')
47-
quick_pick.placeholder = t(
48-
'views.settings.handlers.select-default-api-configuration.placeholder'
49-
)
46+
quick_pick.title = t('common.select-model.title')
47+
quick_pick.placeholder = t('common.select-model.placeholder')
5048
quick_pick.matchOnDescription = true
5149

5250
const close_button: vscode.QuickInputButton = {

‎apps/editor/src/views/shared/actions/api/create/interactions/initial-select-model.ts‎

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,8 @@ export const initial_select_model = async (
7171
const quick_pick =
7272
vscode.window.createQuickPick<vscode.QuickPickItem>()
7373
quick_pick.items = model_items
74-
quick_pick.title = t(
75-
'views.shared.actions.api.create.interactions.initial-select-model.title'
76-
)
77-
quick_pick.placeholder = t(
78-
'views.shared.actions.api.create.interactions.initial-select-model.placeholder'
79-
)
74+
quick_pick.title = t('common.select-model.title')
75+
quick_pick.placeholder = t('common.select-model.placeholder')
8076
quick_pick.buttons = [vscode.QuickInputButtons.Back]
8177

8278
if (last_selected_model_id) {
@@ -162,9 +158,7 @@ export const initial_select_model = async (
162158

163159
while (true) {
164160
const input = await vscode.window.showInputBox({
165-
title: t(
166-
'views.shared.actions.api.create.interactions.initial-select-model.title'
167-
),
161+
title: t('common.select-model.title'),
168162
prompt: t(
169163
'views.shared.actions.api.create.interactions.initial-select-model.prompt'
170164
)

‎apps/editor/src/views/shared/actions/api/update/interactions/edit-model-for-api-config.ts‎

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -90,12 +90,8 @@ export const edit_model_for_api_configuration = async (params: {
9090
const quick_pick =
9191
vscode.window.createQuickPick<vscode.QuickPickItem>()
9292
quick_pick.items = model_items
93-
quick_pick.title = t(
94-
'views.shared.actions.api.create.interactions.initial-select-model.title'
95-
)
96-
quick_pick.placeholder = t(
97-
'views.shared.actions.api.create.interactions.initial-select-model.placeholder'
98-
)
93+
quick_pick.title = t('common.select-model.title')
94+
quick_pick.placeholder = t('common.select-model.placeholder')
9995
const close_button: vscode.QuickInputButton = {
10096
iconPath: new vscode.ThemeIcon('close'),
10197
tooltip: t('common.close')
@@ -190,9 +186,7 @@ export const edit_model_for_api_configuration = async (params: {
190186

191187
while (true) {
192188
const new_model_input = await vscode.window.showInputBox({
193-
title: t(
194-
'views.shared.actions.api.create.interactions.initial-select-model.title'
195-
),
189+
title: t('common.select-model.title'),
196190
value: params.api_configuration.model,
197191
prompt: t(
198192
'views.shared.actions.api.update.interactions.edit-model-for-api-config.prompt'

0 commit comments

Comments
 (0)