London | 26-ITP-May | Russom Gebremeskel | Sprint 3 | Quote Generator - #1438
Open
russom-g wants to merge 3 commits into
Open
London | 26-ITP-May | Russom Gebremeskel | Sprint 3 | Quote Generator#1438russom-g wants to merge 3 commits into
russom-g wants to merge 3 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
russom-g
force-pushed
the
sprint-3/quote-generator
branch
from
August 18, 2026 20:48
79dbd5d to
70b8e5e
Compare
russom-g
added
the
Needs Review
cjyuan
reviewed
Aug 18, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Code looks good.
Could you remove all unused code (instead of making them into comments) to keep the code base clean?
Note: It is a best practice to respect instructions like // DO NOT EDIT BELOW HERE.
Comment on lines
+515
to
+517
| //function pickFromArray(choices) { | ||
| // return choices[Math.floor(Math.random() * choices.length)]; | ||
| //} No newline at end of file |
Contributor
There was a problem hiding this comment.
Unused code should be removed to keep the code base clean.
Author
There was a problem hiding this comment.
All comments and unused code added by me is removed.
cjyuan
added
Reviewed
Contributor
|
Looks good. Well done. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Quote generator app for displaying random quote and the author implemented.