Repository navigation
Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 2 | Module data group sprint 2 - #1499
MattCarolus10 wants to merge 60 commits into
Conversation
…ecks and comments
…comments and whitespace
|
Hi @MattCarolus10 ! Sorry about the labels jumping around, I was using your PR to demonstrate a code review. Good work overall, I've left some comments on a few things that could be improved. Take a look and let me know if you have any questions 🙂 |
|
@MattCarolus10 Looks good! A quick note on commits. You seem to create quite a lot of commits when perhaps they could be combined. Generally speaking a commit should represent a single unit of work. This might be a single test, but it also might be a group of related tests, or even a some tests and the function implementation. For example, you have two separate commits:
These do not need to be separate commits. You could very accurately describe both of these changes with the single description of: "add test coverage for invalid arguments to contains". In general, I'd rather someone do too many commits than too few! But I'd encourage you to think about this in the future to avoid your commit history becoming very clogged up 🙂 |
|
Thank you so much Liam, I’ll take note
Sent from Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Liam310 ***@***.***>
Sent: Monday, 16 November 2026 08:55:56
To: CodeYourFuture/Module-Data-Groups ***@***.***>
Cc: Mathew Shaibu ***@***.***>; Mention ***@***.***>
Subject: Re: [CodeYourFuture/Module-Data-Groups] Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 2 | Module data group sprint 2 (PR #1499)
[https://avatars.githubusercontent.com/u/52577696?s=20&v=4]Liam310 left a comment (CodeYourFuture/Module-Data-Groups#1499)<#1499 (comment)>
@MattCarolus10<https://github.com/MattCarolus10> Looks good!
A quick note on commits. You seem to create quite a lot of commits when perhaps they could be combined. Generally speaking a commit should represent a single unit of work. This might be a single test, but it also might be a group of related tests, or even a some tests and the function implementation. For example, you have two separate commits:
* 4335eb3<4335eb3> - "test: add case for contains function to throw error on null input"
* 417ac1b<417ac1b> - "test: add case for contains function to throw error when no argument is passed"
These do not need to be separate commits. You could very accurately describe both of these changes with the single description of: "add test coverage for invalid arguments to contains".
In general, I'd rather someone do too many commits than too few! But I'd encourage you to think about this in the future to avoid your commit history becoming very clogged up 🙂
—
Reply to this email directly, view it on GitHub<#1499?email_source=notifications&email_token=B4W43WPFNY4AN7OPWKSEMND5ZK6JZA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMOJRGE4DOMBUGAY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6911870401>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/B4W43WPPXVI6PTTS55LIUF35ZK6JZAVCNFSNUABFKJSXA33TNF2G64TZHM3TSOJSGQ2TMMRUHNEXG43VMU5TMMRVGE2TEMZXGM4KC5QC>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS<https://github.com/notifications/mobile/ios/B4W43WM5GQCTTG7YVDOL5EL5ZK6JZA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMOJRGE4DOMBUGAY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> and Android<https://github.com/notifications/mobile/android/B4W43WOZ22BH26AG4KJWSWT5ZK6JZA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMOJRGE4DOMBUGAY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. Download it today!
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Self checklist
Task code
CYF-1083
Changelist
I completed debugging task, implemented test and created function and interpreted codes