Skip to content

Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 2 | Module data group sprint 2 - #1499

Open
MattCarolus10 wants to merge 60 commits into
CodeYourFuture:mainfrom
MattCarolus10:Module-data-group-sprint-2
Open

MattCarolus10 wants to merge 60 commits into
CodeYourFuture:mainfrom
MattCarolus10:Module-data-group-sprint-2

Conversation

@MattCarolus10

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1083

Changelist

I completed debugging task, implemented test and created function and interpreted codes

Comment thread Sprint-2/implement/querystring.js Resolved
Comment thread Sprint-2/implement/tally.test.js Resolved
Comment thread Sprint-2/implement/tally.test.js Resolved
Comment thread Sprint-2/interpret/invert.test.js Resolved
@Liam310 Liam310 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 10, 2026
@Liam310

Liam310 commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Hi @MattCarolus10 ! Sorry about the labels jumping around, I was using your PR to demonstrate a code review.

Good work overall, I've left some comments on a few things that could be improved. Take a look and let me know if you have any questions 🙂

@MattCarolus10 MattCarolus10 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 10, 2026
@Liam310 Liam310 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 16, 2026
@Liam310

Liam310 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

@MattCarolus10 Looks good!

A quick note on commits. You seem to create quite a lot of commits when perhaps they could be combined. Generally speaking a commit should represent a single unit of work. This might be a single test, but it also might be a group of related tests, or even a some tests and the function implementation. For example, you have two separate commits:

  • 4335eb3 - "test: add case for contains function to throw error on null input"
  • 417ac1b - "test: add case for contains function to throw error when no argument is passed"

These do not need to be separate commits. You could very accurately describe both of these changes with the single description of: "add test coverage for invalid arguments to contains".

In general, I'd rather someone do too many commits than too few! But I'd encourage you to think about this in the future to avoid your commit history becoming very clogged up 🙂

@MattCarolus10

MattCarolus10 commented Nov 16, 2026 via email

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants