Repository navigation
Cape Town | 26-ITP-Sept | Leigh Ross | Sprint 3 | Build an alarm clock app - #1511
Open
leigh-ross wants to merge 6 commits into
Open
leigh-ross wants to merge 6 commits into
leigh-ross wants to merge 6 commits into
Conversation
…lashes red when alarm goes off.
| let currentSeconds; | ||
|
|
||
| function setAlarm() { | ||
| clearInterval(countdownTimer); |
There was a problem hiding this comment.
If Set Alarm is clicked while the previous alarm is still flashing, what happens to the existing flashTimer?
To "like" or "dislike" this comment, please follow this link
| document.body.style.backgroundImage = "url('alarmsethamster.jfif')"; | ||
| document.body.style.backgroundPosition = "center"; | ||
| clearInterval(countdownTimer); | ||
| clearInterval(flashTimer); |
There was a problem hiding this comment.
After Stop clears flashTimer, what removes red-bg from .centre?
To "like" or "dislike" this comment, please follow this link
|
The CYF AI review has left comments. It will only review a PR one time. When you have addressed these comments, please request review again and a volunteer will take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1098
Changelist