Repository navigation
Conversation
…ddress.houseNumber} not sure which is best to use.
| if (Array.isArray(object)) { | ||
| throw new Error("contains requires an object"); | ||
| } | ||
| return property in object; |
There was a problem hiding this comment.
The stated invalid inputs also include strings, numbers, null, and no argument. What error does this guard produce for those calls?
To "like" or "dislike" this comment, please follow this link
| const key = decodeURIComponent(parts[0]); | ||
| const value = decodeURIComponent(parts.slice(1).join("=")); |
There was a problem hiding this comment.
What key and value does this parsing produce for the existing full+name=John+Doe test case?
To "like" or "dislike" this comment, please follow this link
| // value is undefined, its not seen in the code at all. | ||
| // Ah error said it is not iterable, i didnt spot the for...of loop there, so its not seeing the value as an option in the object. |
There was a problem hiding this comment.
When the loop starts with the plain author object, does it ever assign a value to value?
To "like" or "dislike" this comment, please follow this link
| // Predict and explain first... | ||
|
|
||
| // it does not make a new line as just pressing enter wont work for that. | ||
| // I was wrong, ingredients is showing [object Object], as it wont log out a full object like this. |
There was a problem hiding this comment.
In the original template, which expression was interpolated at the spot that produced [object Object]?
To "like" or "dislike" this comment, please follow this link
|
The CYF AI review has left comments. It will only review a PR one time. When you have addressed these comments, please request review again and a volunteer will take a look. |
Learners, PR Template
Self checklist
Task code
CYF-1083
Changelist
Worked on tests and fixing code as requested for coursework