Repository navigation
Manchester | 26-ITP-Sep | Precious Moses | Sprint 3 | Alarm clock #1524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
moses77-boop
wants to merge
21
commits into
CodeYourFuture:main
Choose a base branch
from
moses77-boop:Sprint-3-AlarmClock
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+74
−3
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f988648
Update title tag in index.html
moses77-boop 2de2f83
Add showTime function to display remaining time in alarm clock
moses77-boop 253777f
Implement setAlarm function to retrieve and display remaining time
moses77-boop bdffa91
Fix setAlarm function to correctly update and display remaining time
moses77-boop 2e305a0
Refactor setAlarm function to use a timerId variable for clearer inte…
moses77-boop 3fca607
Fix setAlarm function to use the existing timerId variable for interv…
moses77-boop 5da3f11
Add finished state styling for alarm clock background
moses77-boop 39868bc
Fix formatting in setAlarm function
moses77-boop 123f507
Add event listener to stop button to remove finished state
moses77-boop 5821475
Remove finished state class at the start of setAlarm function
moses77-boop af537b5
Add animation to finished state background in CSS
moses77-boop 1b2285a
Refactor flash keyframes for improved readability
moses77-boop 94459aa
Remove background color from finished state in CSS
moses77-boop 29d0c59
Add pause button to alarm clock interface
moses77-boop a7430b4
Refactor countdown logic to improve timer management and ensure consi…
moses77-boop dccac26
Refactor setAlarm function to streamline countdown logic and improve …
moses77-boop 1c7f985
Add togglePause function to manage countdown state and update button …
moses77-boop 261c9ca
Fix capitalization of "Pause" button text in togglePause function
moses77-boop 7cd8c8c
Update pause button text to "Pause Alarm" in togglePause function
moses77-boop 62a2056
Refactor code to set button text change in setAlarm function
moses77-boop 9ca5ce2
Fix pause button text in togglePause function and ensure consistent f…
moses77-boop File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you pause a countdown and then press Set Alarm, what label does the pause button show while the new countdown is running?
To "like" or "dislike" this comment, please follow this link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shows
Resumeand never changes back toPause.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have refactored my code for button text changes.