Skip to content

London | 26-ITP-Sept | Fung Nin Lee | Sprint 2 | Data Group - #1526

Open
leerogerfn wants to merge 9 commits into
CodeYourFuture:mainfrom
leerogerfn:Sprint-2
Open

leerogerfn wants to merge 9 commits into
CodeYourFuture:mainfrom
leerogerfn:Sprint-2

Conversation

@leerogerfn

@leerogerfn leerogerfn commented Nov 14, 2026 •

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1083

Changelist

completed exercise of Data Group Sprint-2

Questions

The PR required us do not upload the files of jest (package.json). When I create the push request. I need to delete those file. But when volunteer request us to made some changes on my work. I have to install the jest again. Do there have some ways to avoid me repeating such steps? Thank you.

@github-actions

This comment has been minimized.

@leerogerfn leerogerfn added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Nov 14, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 14, 2026
@github-actions

This comment has been minimized.

@leerogerfn leerogerfn changed the title London | 26-ITP-Sept | Fung Nin Lee | Sprint-2 | Data Group Sprint-2 London | 26-ITP-Sept | Fung Nin Lee | Sprint-2 | Data Group Nov 14, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@leerogerfn leerogerfn changed the title London | 26-ITP-Sept | Fung Nin Lee | Sprint-2 | Data Group London | 26-ITP-Sept | Fung Nin Lee | Sprint 2 | Data Group Nov 14, 2026
@leerogerfn leerogerfn added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 14, 2026
@LonMcGregor LonMcGregor added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 16, 2026
Comment on lines +16 to +17
"+",
" "

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the second + become for an input like name=Ana+Maria+Garcia?

To "like" or "dislike" this comment, please follow this link

Comment on lines +19 to +21
const value = decodeURIComponent(pair.slice(pair.indexOf("=") + 1)).replace(
"+",
" "

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should an encoded literal plus such as %2B differ from a + used to represent a space? Trace how the value is decoded and then replaced here.

To "like" or "dislike" this comment, please follow this link

Comment on lines +41 to +49
expect(() => tally().toThrow("tally requires an array"));
});

test("throw error for 10", () => {
expect(() => tally(10).toThrow("tally requires an array"));
});

test("throw error for ''", () => {
expect(() => tally().toThrow("tally requires an array"));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is .toThrow(...) invoked in these expectations, and does Jest run an assertion? The same pattern appears in all three invalid-input tests.

To "like" or "dislike" this comment, please follow this link

Comment on lines +10 to +12
if (!pair.includes("=") && pair.length > 0) {
queryParams[pair] = "";
continue;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a bare key such as %24half reaches this branch, is it decoded the same way as a key before =?

To "like" or "dislike" this comment, please follow this link

return queryParams;
}

console.log(parseQueryString("full+name=John+Doe"));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What output appears when another module imports this parser?

To "like" or "dislike" this comment, please follow this link

Comment thread Sprint-2/debug/address.js
Comment on lines +3 to +4
//The function intent to return houseNumber. However, console.log should locate the key
//instead of index. function will return error before fix.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the original address[0] expression runs, does it throw an error or produce a value?

To "like" or "dislike" this comment, please follow this link

Comment thread Sprint-2/debug/recipe.js
@@ -1,4 +1,5 @@
// Predict and explain first...
// Ingredients will return the whole recipe before fix.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does JavaScript render for ${recipe} when recipe is an object?

To "like" or "dislike" this comment, please follow this link

@cyf-ai-code-reviewer cyf-ai-code-reviewer Bot added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 16, 2026
@cyf-ai-code-reviewer

Copy link
Copy Markdown

The CYF AI review has left comments. It will only review a PR one time. When you have addressed these comments, please request review again and a volunteer will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Data-Groups The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants