Skip to content

Manchester | 26-ITP-Sep | Salah Alsabhi | Sprint 3 | Alarm clock - #1527

Open
salahalsabhi wants to merge 1 commit into
CodeYourFuture:mainfrom
salahalsabhi:alarmclock
Open

salahalsabhi wants to merge 1 commit into
CodeYourFuture:mainfrom
salahalsabhi:alarmclock

Conversation

@salahalsabhi

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1098

Changelist

  • Title set to "Alarm clock app"
  • setAlarm reads seconds, shows mm:ss, counts down every 1s
  • Plays alarm at 00:00; Stop pauses sound and resets background
  • Background turns red when alarm finishes (stretch)
  • All 5 tests pass

Questions

No questions.

@salahalsabhi salahalsabhi added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 15, 2026
@LonMcGregor LonMcGregor added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 16, 2026
}

const input = document.getElementById("alarmSet");
let remaining = Number(input.value);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens to the countdown when Set Alarm is clicked with the number field empty?

To "like" or "dislike" this comment, please follow this link

@cyf-ai-code-reviewer cyf-ai-code-reviewer Bot added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 16, 2026
@cyf-ai-code-reviewer

Copy link
Copy Markdown

The CYF AI review has left comments. It will only review a PR one time. When you have addressed these comments, please request review again and a volunteer will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants