Skip to content

London | 26-ITP-SEPT | Abakar Souleyman | Sprint 2 | Module-Data-Groups - #1528

Open
abmhts wants to merge 9 commits into
CodeYourFuture:mainfrom
abmhts:module-Data-group/sprint-2
Open

abmhts wants to merge 9 commits into
CodeYourFuture:mainfrom
abmhts:module-Data-group/sprint-2

Conversation

@abmhts

@abmhts abmhts commented Nov 15, 2026

Copy link
Copy Markdown
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1083

Changelist

Debugged, implemented and interpreted the code across multiple files.

@abmhts abmhts added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 15, 2026
@LonMcGregor LonMcGregor added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 16, 2026
const list_of_items= {};

for (const item of items) {
if (list_of_items [item]) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does list_of_items[item] return on the first occurrence of an item such as "toString"?

To "like" or "dislike" this comment, please follow this link

return invertedObj;
}

console.log(invert);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What output appears whenever a test or another module imports this file?

To "like" or "dislike" this comment, please follow this link

const countryCurrencyPairs = [
["US", "USD"],
["CA", "CAD"],
["GB", "GPB"],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixture uses GPB for GB, and the expected object repeats that value, so this test accepts the wrong currency code. What code should this mapping use?

To "like" or "dislike" this comment, please follow this link

@cyf-ai-code-reviewer cyf-ai-code-reviewer Bot added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 16, 2026
@cyf-ai-code-reviewer

Copy link
Copy Markdown

The CYF AI review has left comments. It will only review a PR one time. When you have addressed these comments, please request review again and a volunteer will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants