Repository navigation
London | 26-ITP-Sep | Mars Adesina | Sprint 2 | Module-Data-Groups - #1530
Open
marscancode wants to merge 32 commits into
Open
marscancode wants to merge 32 commits into
marscancode wants to merge 32 commits into
Conversation
Comment on lines
+5
to
+9
| if (typeof obj === "string") { | ||
| throw new Error("contains requires an object"); | ||
| } | ||
| if (typeof obj === "number") { | ||
| throw new Error("contains requires an object"); |
There was a problem hiding this comment.
What does contains(false, "a") do with these type checks, given the requirement that non-object inputs throw?
To "like" or "dislike" this comment, please follow this link
|
The CYF AI review has left comments. It will only review a PR one time. When you have addressed these comments, please request review again and a volunteer will take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1083
Changelist
Implemented contains, lookup, querystring, tally and invert and added jest tests