Repository navigation
London | 26-ITP-Sep | Mandip Sanger | Sprint 3 | Dead code - #1764
mandipsanger wants to merge 21 commits into
Conversation
|
The files changed in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the 'files changed' tab at the top of the page. Here is an example of a file that has been changed on this branch but shouldn't be: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
|
The files changed in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the 'files changed' tab at the top of the page. Here is an example of a file that has been changed on this branch but shouldn't be: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
|
Hi Mandip! 👋 Thanks for your work on this assignment. I noticed that GitHub is reporting a merge conflict on this PR. Could you please resolve the conflict with the main branch? Also, the automated check previously flagged Sprint-3/2-practice-tdd/count.js as an unexpected file for this assignment. Could you double-check the Files changed tab and make sure the PR only contains changes relevant to the Dead Code exercise? Once these are resolved, we can continue with the code review. Thanks, and keep up the good work! |
|
The files changed in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the 'files changed' tab at the top of the page. Here is an example of a file that has been changed on this branch but shouldn't be: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
|
Thank you for checking. I have tried to replace this original file for over 3 weeks now. Also removed the auto formatting as you can see from the committs have replaced the original file many time but still it is not going through and not making changes. I tried to do with oleg in the workshop too but didnt get sucess. Is there any way you could help with this? It doesn't let me reslove conflicts and merge changes. Does it mean I have to make a new branch and new PR? |
Learners, PR Template
Self checklist
Task code
CYF-1066
Changelist
Deadcode