Repository navigation
Conversation
freebuff "fix the flaky login test" fails with "command-argument value ... is invalid for argument 'command'", because the Freebuff branch declares its positional with choices(['login', 'doctor']). That check runs before the prompt is used, so the initialPrompt the TUI already accepts can never be set from argv, and a launcher has no way to start a session with its task except by typing into the TUI. Take bare words as the initial prompt the way the Codebuff branch already does, while keeping login and doctor as commands.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
freebuff "fix the flaky login test"exits with:The Freebuff branch of
parseArgsdeclares its positional withchoices(['login', 'doctor']), so validation runs before the prompt is used.The TUI already accepts an
initialPromptthreaded fromparseArgsinto thechat component, but the return object hardcodes
initialPrompt: !isFreebuff && args.length > 0 ? ... : null, so a Freebuffbuild can never set it from argv.
That blocks launchers. Agent of Empires starts an agent in a tmux pane with
--extra-argsappended to the launch line, and its dotfiles already pass afirst task that way for other agents (
-- '<prompt>'). For Freebuff there isnothing to hand the task to, so the only workaround is typing into the TUI,
which is what a launcher exists to avoid.
This change accepts bare words as the initial prompt the way the Codebuff
branch already does, and keeps
loginanddoctoras commands:freebuff "fix the flaky login test"initialPrompt: "fix the flaky login test"freebuff logincommand: "login",initialPrompt: nullfreebuff --trust-agents fix ittrustAgents: true,initialPrompt: "fix it"Tests: four cases in
cli/src/__tests__/cli-args.test.tscovering those shapesand the unchanged Codebuff path. No dependency changes.
I ran them with
bun testagainst the patched parser (21 pass, 0 fail) bystubbing only the two workspace imports, since no
bun installwas availablelocally; public CI will run the real suite.