Repository navigation
Conversation
Projects located inside a solution folder (solution explorer's virtual folder) weren't included in a symbol search; as a result, `symbol_workspace` wasn't able to find any symbols located in those projects; consequently, `test_run` couldn't match unit test projects located in solution folders either. This fix addresses this problem by adding an "is this a solution folder?" check in the solution items enumeration logic in the collect symbol path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Projects located inside a solution folder (Solution Explorer's virtual folder) weren't included in a symbol search; as a result,
symbol_workspacewasn't able to find any symbols located in those projects; consequently,test_runcouldn't match unit test projects located in solution folders either. This fix addresses this problem by adding an "is this a solution folder?" check in the solution items enumeration logic in the collect symbol path.Type of Change
feat- New featurefix- Bug fixdocs- Documentation onlyrefactor- Code change that neither fixes a bug nor adds a featuretest- Adding or updating testschore- Maintenance tasksci- CI/CD changesRelated Issues
Checklist
Screenshots (if applicable)
Additional Notes