Skip to content

fix(helm): Trainer strategy should be recreate #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alhendrickson merged 1 commit into from
Oct 20, 2026
Merged

fix(helm): Trainer strategy should be recreate #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions helm-charts/cogstack-ce-helm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

This is a all in one helm chart that runs CogStack on Kubernetes

The description for Community Edition (CogStack CE) can be found [here](../../../../cogstack-ce/_index.md)

## Overview

This chart is an umbrella chart that deploys:
Expand Down
3 changes: 1 addition & 2 deletions helm-charts/medcat-trainer-helm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ These features are not yet existing but to be added in future:
| nginx.image.repository | string | `"nginx"` | Image repository for the nginx server |
| nginx.image.tag | string | `"1.29.1"` | This sets the image tag for the nginx server |
| nginx.resources | object | `{}` | Resources for the nginx container. More information can be found here: https://kubernetes.io/docs/concepts/containers/ |
| nginxUpdateStrategy.type | string | `"RollingUpdate"` | |
| nodeSelector | object | `{}` | |
| persistence.media.size | string | `"8Gi"` | |
| persistence.sqlite.backupDbSize | string | `"300Mi"` | |
Expand Down Expand Up @@ -153,7 +152,7 @@ These features are not yet existing but to be added in future:
| tracing.otlp.http.endpoint | string | `"http://unused:4318"` | |
| tracing.resourceAttributes | object | Adds semantic k8s attributes for tracing | Resource attributes to add to the traces. Can be templated |
| tracing.serviceName | string | `"medcat-trainer"` | |
| updateStrategy.type | string | `"RollingUpdate"` | Used for Kubernetes deployment .spec.strategy.type. Allowed values are "Recreate" or "RollingUpdate". |
| updateStrategy.type | string | `"Recreate"` | Used for Kubernetes deployment .spec.strategy.type. Allowed values are "Recreate" or "RollingUpdate". |
| volumeMounts | list | `[]` | Additional volumeMounts on the output Deployment definition. |
| volumes | list | `[]` | Additional volumes on the output Deployment definition. |

Expand Down
6 changes: 1 addition & 5 deletions helm-charts/medcat-trainer-helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,11 +192,7 @@ fullnameOverride: ""

updateStrategy:
# -- Used for Kubernetes deployment .spec.strategy.type. Allowed values are "Recreate" or "RollingUpdate".
type: RollingUpdate

nginxUpdateStrategy:
# Used for Kubernetes deployment .spec.strategy.type. Allowed values are "Recreate" or "RollingUpdate".
type: RollingUpdate
type: Recreate

# This section builds out the service account more information can be found here: https://kubernetes.io/docs/concepts/security/service-accounts/
serviceAccount:
Expand Down
Loading