feat: Allow Uploading/Importing Game Settings data to/from Database

[bagusnl]

Main Goal

Allowing user to synchronize game settings data including:

• Game settings
• Collapse game/region specific settings
• Collapse playtime data

The data gets uploaded to database server that user sets in app settings

PR Status :

• Overall Status : In Progress
• Commits : In Progress
• Synced to base (Collapse:main) : Not yet (pending build failure fix)
• Build status : OK
• Crashing : No
• Bug found caused by PR : 0

Templates

Changelog Prefixes

  **[New]**
  **[Imp]**
  **[Fix]**
  **[Loc]**
  **[Doc]**

[sentry]

Bug: Guard clauses in OnRegistryDbUploadButtonClick and OnRegistryDbDownloadButtonClick are missing return statements, causing execution to continue after detecting an error, potentially showing a false success message.
_{Severity: HIGH}

Suggested Fix

Add a return; statement inside the if blocks after calling SetApplyTextStatus in both OnRegistryDbUploadButtonClick and OnRegistryDbDownloadButtonClick to halt execution when the database is not properly configured.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location:
CollapseLauncher/XAMLs/MainApp/Pages/GameSettingsPages/GameSettingsPageBase.cs#L211-L215

Potential issue: In `OnRegistryDbUploadButtonClick` and
`OnRegistryDbDownloadButtonClick`, the guard clauses that check if the database is
enabled and initialized are missing `return` statements. When a check fails, an error
message is set, but execution continues. This can lead to an operation being attempted
on an unready database, and the initial error message may be overwritten with a success
message, misleading the user into believing the operation was successful when it was
not.

Also affects:

• CollapseLauncher/XAMLs/MainApp/Pages/GameSettingsPages/GameSettingsPageBase.cs:247~251

_{Did we get this right? 👍 / 👎 to inform future reviews.}

[sentry]

Bug: In PushToDatabase, the exception returned by ExportSettings is discarded, which can lead to uploading corrupt or incomplete data to the database if the export fails.
_{Severity: HIGH}

Suggested Fix

Check the return value of await ExportSettings(...). If it is not null, handle the exception by logging it and preventing the subsequent code from uploading the corrupt temporary file.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location:
CollapseLauncher/Classes/GameManagement/GameSettings/BaseClass/ImportExportBase.cs#L554

Potential issue: The `PushToDatabase` method calls `ExportSettings` but discards its
return value using `_ = await ExportSettings(...)`. Since `ExportSettings` returns an
`Exception` object on failure instead of throwing, any error during the export process
is silently ignored. If an error occurs after a temporary file has been partially
written, the subsequent validation checks (file existence and non-zero size) will pass.
This results in corrupt or incomplete data being uploaded to the database, which will
cause failures when the user later attempts to download and import these settings.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

[sentry]

Bug: In GetFromDatabase, an empty string returned from a database query is not handled, causing an exception and leaving an orphaned temporary file on disk.
_{Severity: MEDIUM}

Suggested Fix

In GetFromDatabase, add a check for string.IsNullOrEmpty(retval) after the existing null check to handle cases where the database returns no data, and return early to prevent the exception and file leak.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location:
CollapseLauncher/Classes/GameManagement/GameSettings/BaseClass/ImportExportBase.cs#L581-L582

Potential issue: In `GetFromDatabase`, if a database query for a blob via
`DbHandler.QueryKey` returns an empty result or a blob in an unexpected format, the
method returns an empty string `""` instead of `null`. The existing check `if (retval ==
null)` does not catch this case. The empty string is then converted to a zero-byte array
and written to a temporary file. When `ImportSettings` attempts to read this empty file,
it throws a `FormatException`. This exception is caught, but the zero-byte temporary
file is not deleted, leading to a file leak on the user's disk.

_{Did we get this right? 👍 / 👎 to inform future reviews.}