Repository navigation
feat: add Loki hosting integration - #2247
Open
meysamhadeli wants to merge 3 commits into
Open
meysamhadeli wants to merge 3 commits into
meysamhadeli wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The gRPC endpoint advertises an unusable TCP URI, and persistence cleanup plus polyglot validation and documentation need correction.
5 open findings
What changed in this PR
Adds a preview Loki hosting integration as a standalone container-backed Aspire service with C#, TypeScript, publishing, persistence, and functional coverage.
Changes:
- Adds Loki resource APIs, endpoints, health checks, connection properties, and mount helpers.
- Adds C# and TypeScript examples plus package documentation.
- Adds app-model, manifest, runtime, persistence, and TypeScript tests.
| File | Description |
|---|---|
README.md |
Adds Loki to the integration catalog. |
CommunityToolkit.Aspire.slnx |
Registers source, test, and example projects. |
src/CommunityToolkit.Aspire.Hosting.Loki/CommunityToolkit.Aspire.Hosting.Loki.csproj |
Defines the preview package. |
src/CommunityToolkit.Aspire.Hosting.Loki/LokiBuilderExtensions.cs |
Implements Loki registration and mount helpers. |
src/CommunityToolkit.Aspire.Hosting.Loki/LokiResource.cs |
Defines endpoints and connection properties. |
src/CommunityToolkit.Aspire.Hosting.Loki/LokiSettings.cs |
Defines configurable container settings. |
src/CommunityToolkit.Aspire.Hosting.Loki/README.md |
Documents basic C# usage. |
tests/CommunityToolkit.Aspire.Hosting.Loki.Tests/CommunityToolkit.Aspire.Hosting.Loki.Tests.csproj |
Defines the test project. |
tests/CommunityToolkit.Aspire.Hosting.Loki.Tests/ResourceCreationTests.cs |
Tests app-model and manifest behavior. |
tests/CommunityToolkit.Aspire.Hosting.Loki.Tests/LokiFunctionalTests.cs |
Tests storage persistence. |
tests/CommunityToolkit.Aspire.Hosting.Loki.Tests/TypeScriptAppHostTests.cs |
Validates TypeScript startup. |
examples/loki/CommunityToolkit.Aspire.Hosting.Loki.AppHost/AppHost.cs |
Demonstrates C# orchestration. |
examples/loki/CommunityToolkit.Aspire.Hosting.Loki.AppHost/CommunityToolkit.Aspire.Hosting.Loki.AppHost.csproj |
Configures the C# AppHost. |
examples/loki/CommunityToolkit.Aspire.Hosting.Loki.AppHost/appsettings.json |
Configures AppHost logging. |
examples/loki/CommunityToolkit.Aspire.Hosting.Loki.AppHost/Properties/launchSettings.json |
Adds AppHost launch profiles. |
examples/loki/CommunityToolkit.Aspire.Hosting.Loki.AppHost.TypeScript/apphost.mts |
Demonstrates TypeScript orchestration. |
examples/loki/CommunityToolkit.Aspire.Hosting.Loki.AppHost.TypeScript/aspire.config.json |
Maps the local integration package. |
examples/loki/CommunityToolkit.Aspire.Hosting.Loki.AppHost.TypeScript/package.json |
Defines TypeScript tooling. |
examples/loki/CommunityToolkit.Aspire.Hosting.Loki.AppHost.TypeScript/package-lock.json |
Locks TypeScript dependencies. |
examples/loki/CommunityToolkit.Aspire.Hosting.Loki.AppHost.TypeScript/tsconfig.json |
Configures TypeScript compilation. |
examples/loki/CommunityToolkit.Aspire.Hosting.Loki.AppHost.TypeScript/eslint.config.mjs |
Configures TypeScript linting. |
examples/loki/CommunityToolkit.Aspire.Hosting.Loki.Api/Program.cs |
Adds the example API. |
examples/loki/CommunityToolkit.Aspire.Hosting.Loki.Api/CommunityToolkit.Aspire.Hosting.Loki.Api.csproj |
Configures the API project. |
examples/loki/CommunityToolkit.Aspire.Hosting.Loki.Api/CommunityToolkit.Aspire.Hosting.Loki.Api.http |
Adds a sample API request. |
examples/loki/CommunityToolkit.Aspire.Hosting.Loki.Api/appsettings.json |
Configures API logging. |
examples/loki/CommunityToolkit.Aspire.Hosting.Loki.Api/Properties/launchSettings.json |
Adds the API launch profile. |
examples/loki/CommunityToolkit.Aspire.Hosting.Loki.ServiceDefaults/Extensions.cs |
Adds shared telemetry and health defaults. |
examples/loki/CommunityToolkit.Aspire.Hosting.Loki.ServiceDefaults/CommunityToolkit.Aspire.Hosting.Loki.ServiceDefaults.csproj |
Defines ServiceDefaults dependencies. |
Files not reviewed (1)
- examples/loki/CommunityToolkit.Aspire.Hosting.Loki.AppHost.TypeScript/package-lock.json: Generated file
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
@dotnet-policy-service agree |
afscrome
requested changes
Oct 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Overview
Adds a preview
CommunityToolkit.Aspire.Hosting.Lokihosting integration for running Grafana Loki in Aspire.Includes:
Outstanding validation differences:
PR Checklist
Other information
This is a new preview hosting integration. CI test discovery includes
Hosting.Loki.Tests.