Repository navigation
Keep regex literals after arrow operators opaque - #15
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused lexer correction has a targeted regression test and no identified blocking issues; exact-head CI remains required before merge.
No open issues 🎉
What changed in this PR
This PR fixes the offline source checker's lexer so regular expressions returned by arrow functions remain opaque rather than producing false source candidates.
Changes:
- Recognizes
=>as a single token, enabling existing regex handling. - Adds a regression test for import- and constructor-like text inside an arrow-return regex.
- Updates the checker’s checksum.
| File | Description |
|---|---|
vm2_nesting_check.py |
Tokenizes arrow operators before the fallback. |
test_source.py |
Verifies arrow-return regex contents produce no source candidates. |
SHA256SUMS |
Refreshes the checker’s SHA-256 checksum. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognize => as a single lexical token before the fallback. This prevents import/call-like text inside an arrow-return regular expression from becoming source candidates. Carries the related Sharp Copilot finding across the bundled lexer copies; no runtime claims or code execution.
Validation: 31 local tests passed, regression and checksum included; git diff --check passed. Require Copilot review and exact-head CI before merge.