Repository navigation
test(hydra-gates): gate 122 is an allowed advisory gate - #874
Closed
rubenvdlinde wants to merge 1 commit into
Closed
rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
Gate 122 (sig-maintainability, #871) shipped as a warning by design: a new gate ships advisory, HYDRA_GATE_SIG_MAINTAINABILITY_BLOCKING=1 blocks. The package invariant test bounds the advisory set by name and was not told, so Package invariants is red on main (run 40879631738) and on every PR. The allowlist now names 122 with its reason. Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Author
|
Superseded: main already lists gate 122 in _ADVISORY_ALLOWED_GATES (landed with #879). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This adds gate 122 (sig-maintainability) to
_ADVISORY_ALLOWED_GATESintest_gate_discarded_counts_and_empty_deltas.sh, with its reason in the allowlist comment.Why
#871 (e6ec56b, 29 Oct) shipped gate 122 as a warning on purpose. Its commit says: "Ships as a warning; HYDRA_GATE_SIG_MAINTAINABILITY_BLOCKING=1 blocks." That follows the fleet rule that a new gate ships advisory, the same reason 114 and 116 are on the list. #871 did not update the test that bounds the advisory set by name. As a result, Package invariants is red on main at 1ef1688 (run 40879631738) and on every open PR, for example #873.
Verified
bash hydra-gates/scripts/lib/test_gate_discarded_counts_and_empty_deltas.shgives: 37 assertions, 0 failures. ARM P4 reports "the advisory (_warn) gates are exactly the allowlisted ones: 7 19 46 112 113 114 115 116 122", and its control still detects an extra_warnsite.This PR was prepared with AI assistance (Claude Code) and needs review by a human contributor before merge.