Repository navigation
test(hydra-gates): allow gate 122 as advisory in the discarded-counts suite - #877
Merged
Merged
Conversation
… suite Gate 122 (sig-maintainability) ships as a warning, with HYDRA_GATE_SIG_MAINTAINABILITY_BLOCKING=1 as its per-repo opt-in, like the other new gates on this list. Since #871 the suite failed on main because the demoted set it found included 122 and its allowlist did not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This adds gate 122 (
sig-maintainability, #871) to_ADVISORY_ALLOWED_GATESintest_gate_discarded_counts_and_empty_deltas.sh, with an entry in the list of reasons above it.Gate 122 ships as a warning, following the fleet rule that a new gate starts as a warning. Its per-repo opt-in is
HYDRA_GATE_SIG_MAINTAINABILITY_BLOCKING=1. Since #871 merged, this suite has failed onmain: it found gates7 19 46 112 113 114 115 116 122reporting as advisory, but the allowlist only had7 19 46 112 113 114 115 116.Verified
origin/main: exit 1, from the allowlist assertion above.-S warningon the suite: exit 0.🤖 Generated with Claude Code