Repository navigation
fix(hydra-gates): bring integriq's DSO files back to its gate-119 baseline - #882
Merged
Merged
Conversation
…er classes integriq put interfaces in front of DSOParserService, DsoAttachmentFetcher and DsoIngestService. Their implementations are already excused as DSO-LV adapter files, so the interfaces are too; without them gate 119 counts three new procedure-named files that are adapter contracts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 30, 2026
…om gate 119 DsoActivityOverview (integriq #2731) is the fourth new procedure-named file and kept integriq's count at 11 against a baseline of 10, failing the required Hydra Gates check on development and on the beta release. It is a read model over DsoActivityTable behind the generic Portal ActivityOverviewInterface. Excused by exact path, with the exception named in the $comment; whether it moves into configuration under decision 188 stays open in integriq#2843. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
WilcoLouwerse
changed the title
Contributor
Author
|
@rjzondervan @remko48 @bbrands02 @SudoThijn could one of you force-merge this PR? I am not allowed to bypass the branch protection myself. Ruben is restructuring the branches tonight and this weekend, so I want this on |
Brings in #884, which turns the changed-path filter suite and with it the required Shared-workflow guard green. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
integriq's interface refactor put
DSOParserServiceInterface,Dso/DsoAttachmentFetcherInterfaceandDsoIngestServiceInterfacein front of three DSO-LV adapter classes. Gate 119 (procedure-code) already excuses those three implementations by exact path inallow.pathPrefixes. The prefix match does not reach the new*Interface.phpfiles, so the gate counts three new procedure-named files that are only adapter contracts. This PR adds the three interface paths next to their implementations.It also excuses
lib/Service/Dso/DsoActivityOverview.php(integriq #2731). That file is a read model overDsoActivityTablebehind the generic PortalActivityOverviewInterface. This is a named exception to decision 188, recorded in the$comment, so the integriq beta release can ship. Whether the overview moves into configuration stays open in integriq#2843; when it does, this entry goes and the baseline drops.Effect on integriq
development: 14 → 10 counted files against baseline 10, so gate 119 (part of the requiredquality / Hydra Gates) passes.Test plan
python3 -m json.toolon the token filetest_gate119_procedure_code_scope.sh: all arms passedcheck_procedure_code.pyagainst integriqdevelopment(with #2842):counted 10 file(s), baseline 10, 29 allowlistedMerge #884 first: it fixes the Shared-workflow guard that is red on
mainand on this PR.🤖 Generated with Claude Code