Repository navigation
fix(federation): refuse DER lengths in a longer form than needed - #1460
Merged
Merged
Conversation
Also pins that a critical flag must be a BOOLEAN in both parsers. Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REVIEW, held. Follow-up to RW149's review of #1459, and stacked on it: the diff shows #1459's commits until that one merges. The change here is the last commit.
What
01 81 01 ff), or a long form with a leading zero byte (82 00 80), as X.690 10.1 requires. A length of 128 (81 80) still reads.Like #1459, every changed outcome is a refusal.
Evidence
tlvstays under McCabe 10 (web 8, extension 6). The new helper takes one parameter.AI-assisted: written with Claude Code (claude-opus-5-5) and checked by the lane before opening.