Repository navigation
chore(sigrid): leave vendored tooling out of the analysis scope - #905
Closed
rubenvdlinde wants to merge 1 commit into
Closed
rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
Exclude .claude/** (Claude Code skills and agent config, partly copied from upstream) from the Sigrid analysis scope. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 1, 2026 19:07
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ❌ | ✅ 636/636 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ⏭️ not run for this diff — no file in this diff matches the code globs, and none carries a source extension — the heavy tier has nothing to decide about it. | ||||
| Newman | ✅ 224/224 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-01 20:52 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Leaves vendored tooling out of the Sigrid analysis scope. Adds a minimal
sigrid.yamlholding only anexclude:list. It sets no model pin, languages or components, so Sigrid's automatic detection and default excludes still apply.Excluded paths, one line each
.*/[.]claude/.*: Claude Code developer tooling (skills, agents, config), partly copied from upstream with its own licence and update script; not part of the shipped app. no tracked files today; the exclusion keeps a later vendored skill out, as happened in shillinq and buildiq. The files stay in the repository for developers.Nothing written as this app's own code is excluded.
Why
Decision of 1 November: exclude
.claude/**and other vendored tooling from Sigrid in every app. Sigrid's default excludes cover.github/but not.claude/.Checked
check_sig_maintainability.py) reads the top-levelexclude:ofsigrid.yaml, so the proxy and Sigrid scope the same files; confirmed its parser returns the new pattern(s) for this tree.sigrid.yamlwhen a repository is published to it; whether SIG uses it for an imported assessment is not documented.AI-assisted (Claude Code); reviewed and submitted by a human.
🤖 Generated with Claude Code