Repository navigation
refactor(bulk-ops): split confirmAction into small helpers - #911
Merged
Merged
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5
…rough small helpers Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ❌ | ✅ 636/636 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 1962/1962 | ||||
| Newman | ✅ 224/224 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-02 06:58 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
confirmActioninDashboardBulkOperations.vuesent one of four bulk requests, picked the changed count out of eight possible keys and built the result summary, all in one method (67 lines, McCabe 22). It now reads as small steps:sendBulkRequestpicks the request for the pending action from a lookup (Object.hasOwn, so an unknown action still sends nothing).parentUuidOrNullandstatusRequestOptionshold the move and status inputs.firstCount,bulkResultSummaryandbulkErrorMessage(module functions) build the summary and the error text.Behaviour is unchanged, including the order in which the count keys are tried, the null handling of
??, and that an unknown action finishes without anawait. The literalt()call stays literal.Review note: this is the bulk delete/move/status path for administrators, so it touches data integrity. No request arguments changed; the golden below pins every call.
SIG (gate 122, lizard 1.24.3)
confirmActiongoes from 67 lines / McCabe 22 to 18 lines / McCabe 5; no new unit is above McCabe 4.Together with #909 this brings vue CCN >10 to 3.90%; vue CCN >5 needs about 19 more unit lines (next PR). Gate 122 ratchet: 0 findings.
Verified
DashboardBulkOperations.golden.spec.js: 192 cases (6 actions including an unknown and a prototype key, 18 response shapes, 4 failure shapes, 10 form inputs), recording the API call and its arguments, the result summary, the error text, the selection left behind, reloads and the running flag. Recorded on the old code (first commit) and re-run in plain mode on old and new: pass.timeout 120, 1.5 GB heap, file restored after each): old code 15 of 16 killed, new code 19 of 19 killed. The one survivor on the old code (response?.data || {}to?? {}) is equivalent. A whitespace-only control survives on both.npx vitest run src/components/admin/__tests__/: 10 files, 55 tests pass. eslint and prettier--checkon the changed files: exit 0.AI disclosure: prepared with Claude Code (claude-opus-5-5) and reviewed by the lane before opening.
🤖 Generated with Claude Code