Repository navigation
ci(quality): block on the SIG unit ratchet and commit the SIG score floor - #925
Merged
Merged
Conversation
…loor Sets hydra-gates-sig-blocking, so gate 122 fails a change that adds or worsens a unit over the SIG 4-star bounds. Adds .github/sig-floor.json, generated by check_sig_floor.py write from development b8b0154: the 4-star checks this app meets now, which gate 123 keeps met on every change. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 2, 2026 17:26
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ❌ | ✅ 636/636 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 1962/1962 | ||||
| Newman | ✅ 224/224 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-02 18:54 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
hydra-gates-sig-blocking: true: gate 122 (SIG unit ratchet) now fails a change that adds or worsens a unit over NLOC 60, McCabe 10 or 5+ parameters, or adds a new 6+ line duplicate. Units the change does not touch, or does not make worse, stay inherited..github/sig-floor.json: the 24 SIG 4-star checks this app meets on development b8b0154, generated withcheck_sig_floor.py write .. Gate 123 (feat(hydra-gates): gate 123, a per-app SIG score floor checked on every change .github#891) keeps them met on every change. Until chore(openspec): archive zuiddrecht-showcases and drop the resurrected spend-analytics change #891 is on .github main the file is inert.CI configuration only, no app code.
Verified
quality.ymlcall.AI-assisted: written with Claude Code (claude-opus-5-5).