Repository navigation
refactor(aangeboden-gebruik): remove two ownership checks nothing calls - #1380
Merged
Merged
Conversation
checkOrganisationOwnership and getApplicationsOwnedByOrganisation were never called (PHPStan baselined both as unused). They duplicate the ownership check that getKoppelingenGebruikByUuid does inline, added in the same commit (919697e), so removing them leaves no access gap. Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ✅ | ||||
| composer | ❌ | ✅ 127/127 | |||
| npm | ❌ | ✅ 807/807 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 1486/1486 · 20 skipped | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-02 22:33 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
AangebodenGebruikService::checkOrganisationOwnershipandgetApplicationsOwnedByOrganisation(160 lines) and their two PHPStan baseline entries. Both are private and nothing calls them; PHPStan baselined both as unused.They are not a missing guard. Both duplicate the ownership check that
getKoppelingenGebruikByUuiddoes inline, added in the same commit (919697e). RW40 reviewed this and found no access gap. I left them out of #1374 for that review.SIG
No check moves on its own. Neither method took 3 or more parameters; php unit LOC drops by about 116.
Verified
--fail-on-risky: 1,506 tests, the same 20 errors as development (Doctrine\DBAL\ParameterTypemissing locally), 0 risky.phpunit.xml's server bootstrap, as on development).AI disclosure: prepared with Claude Code (claude-opus-5-5) and reviewed by the lane before opening.