Repository navigation
fix(organisations): check that an organisation belongs to the organisatie before linking (REVIEW) - #1422
Merged
rubenvdlinde merged 2 commits intoNov 4, 2026
Conversation
…that is not its own The sync links an organisatie to the OpenRegister organisation with its uuid. It now does so only when that organisation is at least as new as the object, or when an administrator linked the two, and counts the rest under organisationIdConflicts. An anonymous organisation create carrying such a uuid is refused. The link command refuses when OpenRegister cannot name its default organisation, records the link, and can confirm a refused pair. Assisted-by: ClaudeCode:claude-opus-5-5
…gistration-id-binds-organisation
Contributor
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 127/127 | |||
| npm | ❌ | ✅ 807/807 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | 🚨 NO VERDICT — enabled but never ran | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ⏭️ |
Quality workflow — 2026-11-04 07:27 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
marked this pull request as ready for review
November 4, 2026 11:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sync links an organisatie to an existing organisation only when that organisation is at least as new as the object, or when an administrator linked the two. Other cases are logged and counted under organisationIdConflicts. An anonymous create that carries such a uuid is refused. The link command refuses when OpenRegister cannot name its default organisation, records a link, and can confirm a refused pair.
Verified: failing-first tests, touched tests, phpcs, phpmd and phpstan on touched lib files, capped mutants with surviving controls. One survivor is equivalent.
Not done: the full suite and hydra gates did not run (wind-down), so this stays a draft until they have. Not run on a live instance. Before merging, check stored data for pairs where the organisation is older than the object: they would be refused.
🤖 Generated with Claude Code