feat(reports): preserve unexplained-leftover comparison delta pending successor verification - #832
Draft
seonghobae wants to merge 1 commit into
Conversation
…on strip (v2.54.0) Caption persisted leftover-map unexplained leftover U = R − R̂ on grouping comparison leftover-pair buttons through formatLeftoverMapUnexplained (ADR 0297). Distinct aria-label Leftover map comparison unexplained leftover. Missing or non-finite U omits that badge and keeps x, s, e, R̂, d, and coverage notes. Do not invent U from R and R̂. Rank-0 origin cells still name U 0.00 when finite. Finite negative leftover is shown, never clamped. UI-only; no new columns.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This was referenced Aug 30, 2026
feat(reports): preserve grouping-comparison unexplained-leftover delta for serialized successor
#833
Draft
seonghobae
changed the title
seonghobae
marked this pull request as draft
September 7, 2026 08:16
seonghobae
added
enhancement
ChatGPT Codex Connector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovery status
This PR is an open Draft recovery/evidence lane. Historical head
1511166c53c16fef65f3330eee58d3a5664b1583introduced a valid persisted grouping-comparison unexplained-leftoverUpresentation delta, helper/i18n/App regressions, ADR0297 evidence, release metadata, and generated-lock version change. It was previously closed before complete successor inheritance had been proven, so keep it open under the no-drop rule. Do not merge this historical head or resume product source writing here.Current serialized prerequisite
The live repair order is #828 → #829 → #830 → #831 before #833 may reconstruct this delta.
1472d98b7513c360ca1c7cf6da4a401a716bc53c, Draft/RED. test(#828): verify grouping axis-share accessible semantics #981's dedicated accessibility regression is already merged into the feat(reports): preserve grouping comparison axis-share delta for serialized successor #828 product tree. Exact product-head run34180159005proves the grouping axis-share plain<span>still carries an authoraria-label. Fresh owner review also found the repair contract must update Proposed ADR0367 and the v2.54.0 changelog, which still require/claim distinct accessible naming; source-only deletion would leave normative docs stale. The repair must preserve visible localized persisted share text without adding a synthetic role, then recollect exact-head acceptance.cad63edba68981a1ae3223e2f525284fc9d4ef0fon exact feat(reports): preserve grouping comparison axis-share delta for serialized successor #828. Its distinct persisted unexplained-share read-model repair remains valid product delta, but prior-parent GREEN does not transfer across the pending feat(reports): preserve grouping comparison axis-share delta for serialized successor #828 movement.367498ed59396f490ce9b475175d748f7c43fc31on exact feat(reports): preserve grouping comparison unexplained-share delta for serialized successor #829. Its local axis-singular accessibility repair was proven on an earlier validation head; current ancestry still inherits feat(reports): preserve grouping comparison axis-share delta for serialized successor #828 RED and must be refreshed after feat(reports): preserve grouping comparison axis-share delta for serialized successor #828/feat(reports): preserve grouping comparison unexplained-share delta for serialized successor #829 move.367498ed..., while its historical product head remains8a12062cd8efef0c99abe794ef3e9f8dcbc31617and GitHub reports it conflicting. Keep it Draft; reconstruct only after predecessors are repaired. Proposed ADR0372 is the current decision identity; release identity remains deliberately unallocated until reconstruction against then-live authority.No predecessor or validation GREEN transfers across that required parent movement.
#833 successor inheritance
#833 is the intended live successor for the same
Uproduct behavior, but #832 head1511166c...and #833 feature origin are sibling deltas over the historical #831 parent rather than ancestor/descendant commits. Reconstruction must explicitly preserve this lane's valid invariants: finite/missing/non-finite/negative/zero persisted-Ubehavior; helper/i18n/App regressions; the assertion thatLEFTOVER_MAP_COMPARE_UNEXPLAINED_LABELis distinct from the unexplained-share label; regenerateduv.lock/project-version parity rather than hand edits; and all valid fixture/contract/evidence. Historical ADR0297/v2.54.0 is evidence only because current #828 owns v2.54.0.Close criterion
Close this recovery PR only after exact reconstructed #833 on the repaired serialized parent proves complete inheritance of every valid delta/test/fixture/contract/evidence item above, current collision-free ADR/release identity, regenerated lock parity, and fresh exact-head required checks. Until then it remains Draft recovery authority. No force-push, destructive rebase, self-approval, gate weakening, source duplication, psychometric recomputation, ancestor bypass, or stale-head evidence transfer.