feat(network): admit typed WebDriver BiDi text-input results - #268
feat(network): admit typed WebDriver BiDi text-input results#268seonghobae wants to merge 19 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Text-response integration writer RELEASED — 2026-09-06 14:35 UTC Root task01a06c0f-b427-7830-b654-9addcdfe7aff releases #268 after publishing ba43d61 on live2674435ce5f561ca069c1844a1a5bd9b603505e25f7. Ordinary merge5e465a8f preserves history; REDa9446fbc and fixcd93d9fc enforce TypeText-only success/error correlation. Full local gates,145 Python contracts,100% four production coverage dimensions and actual Edge visual inspection passed. CI34039611139 remains queued, no formal reviews. Receipt provenance is a separate next repair, not completed by family isolation. No merge/gate/workflow/secret/release changes. Worktree/private/tmp/originweave-pr268-adoption.4vetEa preserved with coverage artifact; no active test process. |
Commit-Message-Assisted-by: Codex (via Codex) Signed-off-by: Seongho Bae <me@seonghobae.me>
Signed-off-by: Seongho Bae <me@seonghobae.me>
Commit-Message-Assisted-by: Codex (via Codex) Signed-off-by: Seongho Bae <me@seonghobae.me>
Commit-Message-Assisted-by: Codex (via Codex) Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Published integration verification — 2026-09-06 14:35 UTC Exact head ba43d61 / live base4435ce5f561ca069c1844a1a5bd9b603505e25f7 confirmed. Full local gates and 145 repository contracts pass; pinned production coverage1324/1324 functions,13884/13884 lines,17666/17666 regions,1456/1456 branches. Artifact SHA2569cb4b499f3bc3177f767b80513218238b7aba45f23e6345c01d2cb9cd510a945. Independent read-only review found no actionable issue, not counted approval. Actual Edge visual inspection of the updated rendered PR confirmed current head/base, Draft state, readable evidence, and no visible clipping or overlap in the inspected viewport. This is GitHub presentation evidence, not OriginWeave runtime evidence. Fresh hosted CI34039611139 has Rust101503858210 and coverage101503858480 QUEUED. Formal reviews remain empty; advisory statuses are not approvals. Receipt provenance and observed text-value success remain unfinished. No merge, bypass, workflow, secret, release or tag change. |
|
Text receipt-provenance writer RELEASED — 2026-09-06 14:49 UTC Root task01a06c0f-b427-7830-b654-9addcdfe7aff publishes/readbacks child e567af9 on canonical parent3346d8ecc72932b98ec495d9cc52d6e5727c3064. Actual RED4632f2df (replacement response accepted), REDd6889c80 (missing sender generation), owner fix3346d8ec, ordinary mergee1188c86 and fixture35cb1197 are preserved. Seven focused tests, full Rust gates,145 Python contracts and100% coverage1324/13890/17670/1456 pass. Artifact SHA2565865d6e69dc5584bad8ef4e866970eb6aa845ad692aa5421a0ffb6f6f01e1540. Independent review no actionable findings, not approval. Actual Edge screenshot of published current PR verifies exact head/base, Draft, readable text/evidence and no visible clipping/overlap in inspected viewport. Hosted CI34040306372 Rust101505730639/coverage101505730770 QUEUED. No product-runtime, protected-main or release acceptance. Pointer/status provenance and pointer outbound session binding remain separate gaps. Worktree/private/tmp/originweave-pr268-adoption.4vetEa retained with artifacts; no active processes or writer. No workflow/gate/approval/merge/release change. |
Commit-Message-Assisted-by: Codex (via Codex) Signed-off-by: Seongho Bae <me@seonghobae.me>
Commit-Message-Assisted-by: Codex (via Codex) Signed-off-by: Seongho Bae <me@seonghobae.me>
Signed-off-by: Seongho Bae <me@seonghobae.me> # Conflicts: # CHANGELOG.md # docs/traceability/action-postcondition-evidence.md
Commit-Message-Assisted-by: Codex (via Codex) Signed-off-by: Seongho Bae <me@seonghobae.me>
Commit-Message-Assisted-by: Codex (via Codex) Signed-off-by: Seongho Bae <me@seonghobae.me>
|
OriginWeave hourly writer acquires one bounded #268 PR-state/evidence-only slice at verified exact head Fresh hosted evidence has completed on the unchanged head: CI |
|
#268 PR-state/evidence writer RELEASED. Exact head remains |
|
Writer lease RELEASED — root task 01a06c0f-b427-7830-b654-9addcdfe7aff, 2026-09-07 01:23 UTC. Published/read-back head ff27220 on parent267 ebd507a, Draft. Actual three-case RED716fd842 → ordinary merge34e537b1 preserves all original text/core source and tests. Historical-doc review finding: actual RED49d18f5f → ba22e9a/ff27220c; independent read-only reviewer confirms resolved with no new findings, not formal approval. 20 focused tests, full Rust1.97.1 format/check/test/Clippy/rustdoc,146 Python contracts,compileall,healthy CodeGraph/diff pass. Coverage1325/13907/17682/1456 all100%; artifact SHA256 bce553c93d5b5dd3cb59c78bbb75c9f1225b659ec7ea22b674c54455e5067a07. Instrumentation warning retained. Exact-head CI34072645796 Rust101592712272/coverage101592712193 remain QUEUED, not passing evidence. Actual isolated Edge screenshots inspected: /tmp/pr268-published-ff27220c.png and /tmp/pr268-historical-ff27220c.png. Current PR head/base/Draft, evidence paragraphs, Historical heading, predecessor35cb1197 and later-adoption link render readably with no visible clipping or overlap in inspected1440px viewports. Documentation visual evidence only, not product-runtime acceptance. Prior adoption screenshot /tmp/pr268-published-fcd49b53.png also retained. Full prior hourly contributor PR evidence preserved and body readback verified. Worktree /private/tmp/originweave-pr268-adoption.4vetEa and all four untracked coverage artifacts retained. No active local verification/browser process or writer remains. No force, workflow, ruleset, secret, counted approval, merge, tag or release mutation. Next dependency-safe source item is #269 parent adoption, after fresh lease/remote checks. |
Current pointer-parent adoption — 2026-09-07
Exact head
ff27220cb5eb4d11ca1dc5614a4181e1a397a3f1adopts parent #267ebd507ae56c3064e3cae5566502f539c20618a8fby ordinary merge34e537b1, preserving all text source, tests and core crate frome567af9e. Actual RED716fd842reproduced three foreign-session/replacement-response failures before adoption; 20 focused tests now pass. The historical documentation finding was reproduced at49d18f5f, corrected atba22e9ad, and linked directly to later evidence atff27220c. Independent read-only review found it resolved, with no new findings; this is not formal approval.Full Rust 1.97.1 formatting, locked workspace check/tests, strict Clippy and warning-denied rustdoc pass, along with 146 Python contracts, compileall, healthy CodeGraph and diff checks. Production coverage is 1325/1325 functions, 13907/13907 lines, 17682/17682 regions and 1456/1456 branches. Artifact
coverage-historical-checkpoint.jsonSHA256bce553c93d5b5dd3cb59c78bbb75c9f1225b659ec7ea22b674c54455e5067a07; the unstable branch-instrumentation warning remains visible. Production is byte-identical to reviewedfcd49b53.Fresh hosted checks and visual inspection are tracked separately below; predecessor hosted success applies only to its recorded head. Keep Draft. Observed field values, authenticated browser ownership, status-response adoption and protected-foundation integration remain unproven. No workflow, ruleset, approval, merge, tag or release change.
Preserved predecessor evidence
Current connection-bound text responses — 2026-09-06 14:49 UTC
Exact head
e567af9e678fd4791776df795e89ed666975e6c2adopts published #267 sender3346d8ecc72932b98ec495d9cc52d6e5727c3064through ordinary mergee1188c86. Both histories are preserved. Keep Draft.Actual RED
4632f2dfaccepted a success reply from a replacement socket using the same listener and session. Sealed consumerd6889c80exposed missing sender provenance. The canonical parent now retains its private connection generation before I/O; this consumer requires the existing sealed received-message type and checks that generation before consuming pending state. No caller-supplied generation or raw-message fallback exists.Seven focused tests pass: foreign success/error rejection with original-connection recovery and unrelated pending-state retention, real matched success/remote error, missing sender provenance, all five wrong families, malformed envelopes and unknown identifiers. Original extensible results, payload-free errors, session/current-node checks and uncertain-write retention remain intact. Independent read-only combined review found no actionable issue; it is not a formal approval.
Exact local evidence
Rust1.97.1 formatting, locked all-target/all-feature check, full workspace tests, strict Clippy, warning-denied rustdoc,145 Python contracts,compileall,CodeGraph and diff checks pass. Pinned production coverage is100%: 1324/1324 functions,13890/13890 lines,17670/17670 regions,1456/1456 branches. Local
coverage-receipt-provenance.jsonSHA2565865d6e69dc5584bad8ef4e866970eb6aa845ad692aa5421a0ffb6f6f01e1540.Fresh hosted exact-head CI
34040306372is terminal success one567af9e678fd4791776df795e89ed666975e6c2. Rust contracts101505730639passed repository contracts, canonical formatting, workspace check, full tests, strict Clippy and API documentation. Production coverage101505730770passed exact measurement, diagnostics upload and exact coverage enforcement. This repository-native GREEN does not establish browser-process ownership, action authorization, observed field values, protected-main delivery, independent approval or release acceptance. Pointer and status response consumers still require their own receipt-provenance repairs. Earlier evidence below is historical, including its now-repaired text receipt gap.Historical predecessor evidence
Current integration — 2026-09-06 14:35 UTC
Head
ba43d61cc7617b855b7ce775845fef20162d2c6dnow adopts live #2674435ce5f561ca069c1844a1a5bd9b603505e25f7through ordinary merge5e465a8f, preserving both histories. GitHub readback confirms these exact head/base identities and Draft state.Text-entry replies cannot consume another command family's pending request. RED
a9446fbcrequires success/error rejection across all five sibling families; adopting the parent then exposed the removed generic correlation call. Fixcd93d9fcreuses the existing TypeText guard. Five focused tests pass, including ten wrong-family cases. Original extensible success, malformed/unknown retention, exact remote-error consumption and real send/receive round trip remain intact. Parent text transport is byte-for-byte unchanged.Local exact-head verification
Formatting, workspace/all-target/all-feature check, complete workspace tests, strict Clippy, warning-denied rustdoc, 145 Python contracts, Python compilation, CodeGraph sync and diff checks passed. Pinned nightly production coverage is 100%: functions 1324/1324, lines 13884/13884, regions 17666/17666, branches 1456/1456. Local artifact
coverage-ba43d61c.jsonSHA-256:9cb4b499f3bc3177f767b80513218238b7aba45f23e6345c01d2cb9cd510a945.Independent read-only review found no actionable family-isolation or preservation issue; it is not a formal GitHub approval. Current formal reviews are empty. Fresh hosted checks are not yet established as passing; predecessor CI and advisory status success are not current-head acceptance.
Remaining boundaries
The assembled response still lacks connection-bound receipt provenance, and the text sender does not yet retain its connection generation in correlation. That requires a separate sender/consumer repair using the existing shared receipt APIs. A protocol acknowledgment does not prove the field changed, authorize an action, authenticate a browser, or supply protected-main/release acceptance. Keep Draft. Live ruleset18156473 still requires eligible approval, central workflows and thread resolution; no bypass is used.
Historical predecessor evidence — not current-head acceptance
Partial implementation of #28, stacked directly on PR #267 branch
feat/webdriver-bidi-node-type-text-transportexact head46a05d7f8a1219803cafb38fc33deb263a1c14cc.Buyer-visible boundary
This slice adds command-specific correlated response admission for node-bound WebDriver BiDi
input.performActionstext input. The boundary validates one already bounded complete local-end JSON envelope before touching correlation state, consumes exactly the matching outstanding command id, accepts the extensible successresultonly as a protocol acknowledgment, and converts a correlatable remote protocol error into a typed failure. Malformed envelopes and unknown ids fail closed without consuming unrelated outstanding state.Protocol acknowledgment remains deliberately separate from buyer-visible post-condition success: this PR does not claim that the target field actually contains the requested text or that DOM/accessibility state changed.
Test-first lineage
Exact RED head
01c82b406cebcead98b276a89d8bdbeb82fe4b42added a realistic loopback TCP → RFC 6455 regression that sends a real node-bound text-input action through the public transport, reads the bounded server text frame, and requires a typedWebDriverBiDiTypeTextResultto consume exactly command id 42. The result type did not yet exist at that head, so compilation failed as intended.The first implementation candidate
c16e96cac958563cb15a6c23ec23bae305fc85d3then exposed a canonical rustfmt defect in CI run33454471153. Its generatedrustfmt-c16e96cac958563cb15a6c23ec23bae305fc85d3diagnostic identified only deterministic formatting changes in the new response module and hostile-response regression file. Those exact formatter changes were applied without weakening tests or changing the authority contract.Exact-current evidence
Current exact head is
8d4027e40b790d28d866051ba741db12927ec22cagainst independently resolved live base46a05d7f8a1219803cafb38fc33deb263a1c14cc. GitHub reports the PR open, Draft, and mergeable.Exact native CI run
33457416485completed success on this unchanged head:99700272215: repository contracts, canonical formatting, workspace check, full tests, strict Clippy, and public API documentation/rustdoc success;99700272012: exact owned-production function/line/region/branch measurement and enforcement success.Exact coverage artifact
9781972604(exact-coverage-8d4027e40b790d28d866051ba741db12927ec22c) has digestsha256:e5c29eafce251df0b78b05e1f1aa74fec0166a14c76c1435e3eed9b4ee451408.Fresh exact-head check inventory contains only the two repository-native CI jobs above; absent organization/default-branch workflows are not promoted to passing evidence on this stacked Draft. Fresh formal review inventory is empty, so no independent approval is claimed or inferred. No predecessor, skipped, queued, cancelled, stale, synthetic, model-only, author-only, or status-only evidence is promoted to this exact head.
Stack / authority boundary
Keep Draft while #267 and its ancestors remain Draft. The next #28 slice must independently prove an observed text-entry post-condition rather than treating this correlated protocol acknowledgment as task success.
Protected-main
AGENTS.mdand live GitHub governance remain authoritative. This scheduled writer does not merge, self-approve, force-push, destructively rebase, alter workflows/rulesets/secrets, weaken checks, tag, release, or publish.