test(mv3): prove bounded bookmark mutation compatibility - #56
test(mv3): prove bounded bookmark mutation compatibility#56seonghobae wants to merge 26 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Stale comment
Review — PR #56 bookmark mutation
Verdict: the create → get → remove lifecycle is the right compatibility slice, and the pinned-Chromium MV3 fixture job on
82403ecalready succeeded. This draft is still not merge-ready as an operator-actionable close.What is sound
- Mutation is bound to
http://127.0.0.1/page.htmlwithout userinfo.finallyalways attemptschrome.bookmarks.remove.- Raw
_error.messageis not retained.- Chrome
bookmarkspermission is not treated as an OriginWeave Agent grant.- Stacked draft on #43 /
test/mv3-downloadsis the correct dependency order.What still blocks a buyer-visible close
Bookmark failures collapse to
bookmarks: missingwith no classified stage. Downloads already emit allow-listed tokens (download-source-rejected,download-complete-ready, …). Without the same contract here, an operator cannot tell source rejection from create failure, get mismatch, or leftover residue afterremovefails.The unique commit also omits the current
chrome.bookmarksAPA 7th primary citation that the downloads lane already requires.Next action
Do not merge this draft while #43 is still the prerequisite and while bookmark failures stay unclassified. The diagnostic close is on
cursor/bc-62f8754b-f579-4115-9089-cace87f78155-206a(054708a): allow-listed bookmark stage tokens, runner sanitization, and the current Bookmarks API citation. Keep #59/#60/#61 stacked behind that close. Compatibility success remains evidence only — not Agent bookmark authority.Cannot approve: this identity authored the head. Formal approval stays with an eligible non-author reviewer if current rules require one; solo-maintainer independent-review remains on hold.
Sent by Cursor Automation: Fix Issues
There was a problem hiding this comment.
Review — exact head cea76b9e129d02a093ae237804e47ee3a4a08a6c
The new commit only realigns this draft with the downloads transport-protocol classification. The buyer-visible diagnostic gap is unchanged: exerciseBookmarkMutation still returns a boolean, so create failure, get mismatch, and leftover residue after remove all collapse to bookmarks: missing.
Prior threads remain not addressed on this head:
- allow-listed bookmark stage tokens (
bookmark-source-rejected…bookmark-complete-ready) - runner sanitization of
bookmarksDiagnostic(raw Chrome errors / fixture titles →unexpected) - current
chrome.bookmarksAPA 7th primary citation
Pinned Chrome for Testing MV3 fixture already succeeded on this head. Rust contracts and Production coverage were still in progress at review time and are not treated as passing.
Next action
Do not merge this draft. Keep #43 as the downloads prerequisite. The diagnostic close is #178 44cbfc2 (test(mv3): require bounded bookmark mutation diagnostics). Do not open a third bookmark-diagnostic pull request. Keep #59/#60/#61 stacked behind that close. Compatibility success is not OriginWeave Agent bookmark authority.
Cannot approve: this identity authored the head. Formal approval stays with an eligible non-author reviewer if current rules require one; solo-maintainer independent-review remains on hold.
Sent by Cursor Automation: Fix Issues
Preserve the current bookmark diagnostic tree while adding exact ancestry to PR #56 head 71420d0. The diagnostic branch already contains the bookmark mutation lifecycle plus the same hardened downloads-root changes; this non-destructive merge repairs stack topology without transferring predecessor checks or reviews.
Rebuild the diagnostic lane on the exact current PR #56 tree while preserving the bounded bookmark diagnostic source/test delta. Keep the prerequisite ChromeDriver cleanup resilience and extension-authority hardening, retain the dedicated MV3 doctoring evidence, and avoid reintroducing duplicate/stale generic doctoring/TRD claims. No predecessor check or review evidence transfers.


Partial implementation of #27, stacked on live PR #43.
Buyer-visible gap
The pinned real-Chromium MV3 lane previously proved bookmark API visibility without proving a controlled mutation lifecycle. A defensible compatibility claim also needs one synthetic create/read/delete bookmark cycle, bounded stage diagnostics, and residue cleanup without touching an ambient human profile.
Fresh live stack
Current exact prerequisite PR #43 head is
28e79febd47361c5fd41e45db7e1429b179afdd1(test/mv3-downloads). Current exact child head is03f8e37909d417548717dc50223d778b103945e1(test/mv3-bookmark-mutation).Fresh exact comparison #43 → #56 reports ahead 26 / behind 0, with merge base exactly the live prerequisite. The current child-owned semantic delta is exactly five files:
scripts/ci/run_mv3_compatibility.py;tests/fixtures/mv3_basic/content_script.js;tests/fixtures/mv3_basic/service_worker.js;tests/test_mv3_bookmark_mutation_contract.py; andtests/test_mv3_bookmarks_history_contract.py.The previously documented parent/head pair
ecaac90f.../70c2c364...and three-file delta are predecessor narrative only. No prerequisite/predecessor check or review transfers.Implemented boundary
The controlled fixture:
http://127.0.0.1/.../page.htmlsender with no embedded credentials;finallycleanup and fails compatibility evidence if cleanup fails;bookmarksDiagnosticstage tokens for source rejection, create/get/id/title/url mismatch, remove failure, success, or not-evaluated state;unexpectedbefore evidence publication;The process proves Chromium compatibility only. It does not convert extension permission into OriginWeave Agent bookmark authority.
Exact-current evidence
On unchanged exact child head
03f8e37909d417548717dc50223d778b103945e1against unchanged exact prerequisite28e79febd47361c5fd41e45db7e1429b179afdd1:CIrun33201021332: success;Manifest V3 Compatibilityrun33201021375: success;Feature-base organization security/review workflows not executed for this exact head are absent evidence, not passing. No prerequisite, predecessor, queued, skipped, cancelled, synthetic, status-only, or model-only result is promoted as current proof.
Scope / governance
This is compatibility evidence only. It does not grant OriginWeave Agent bookmark authority, expose a general bookmark tool, mutate a human profile, add model calls, create persistence ownership, or complete the full issue #27 extension matrix. Chromium permission and browser compatibility remain separate from OriginWeave Agent capability/policy authority.
Keep Draft while #43 remains active. #43 itself is materially diverged from protected main and contains a workflow-authority delta owned by issue #212, so this child must not be treated as integrated-main evidence. Protected-main
AGENTS.mdforbids this scheduled actor from merging, self-approving, altering workflows, adding secrets, weakening checks, tagging, or publishing.