fix(ui): keep drag-over state stable across nested drop-zone elements - #533
fix(ui): keep drag-over state stable across nested drop-zone elements#533seonghobae wants to merge 2 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Current exact authority — 2026-09-06
main@47c6fd27de13b0da37a7db64697b8699419093512793248abed72a3c0accd0c584ff77f793395dd8saas_web.pyonlyProduct finding
The existing drop-zone handlers add
.dragoverondragenter/dragoverand remove it on everydragleave. Moving a dragged file between the drop zone and nested label/input descendants can therefore make the parent observe leave/enter transitions even though the pointer has not left the overall drop target, producing unstable highlight state.The branch introduces per-zone nesting state:
dragenterincrementsdragCounter,dragleavedecrements it and clears.dragoveronly at zero, anddropresets both counter and visual state. Single-file and batch zones share the same setup path.Scope repair
The generated predecessor also appended a blanket
dragCounterprescription to.jules/palette.md. That repository-wide doctrine was not necessary to express this product-local interaction repair. Normal descendant2793248abed72a3c0accd0c584ff77f793395dd8restores.jules/palette.mdbyte-for-byte to protectedmain; no force push or destructive rebase was used.Remaining acceptance
There is no current-head behavioral browser/E2E evidence yet, so the visual claim is not promoted as complete. Before Ready, exercise both single and batch drop zones in a real browser with at least: enter from outside, movement across nested label/input descendants, leave to outside, drop, and a second drag after drop. Verify
.dragoverdoes not flicker or stick, counter state resets between gestures, native file selection remains unchanged, and keyboard/form behavior is unaffected.Fresh exact-head CI, fuzz, Security Scan, SAST Semgrep and CodeQL PR runs are newly materialized and non-terminal. Predecessor results do not transfer.
Delivery Gate
No Ready/merge promotion until one unchanged exact head satisfies the material UI evidence, hosted security/CI gates, current review threads, and independent non-author review. No self-approval, bypass, source-neutral retrigger, gate weakening, force push, or destructive rebase.