test(support): bind support-bundle counts and secret redaction - #134
test(support): bind support-bundle counts and secret redaction#134seonghobae wants to merge 6 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough지원 번들 테스트가 KPI 및 증거 매니페스트의 런타임 카운트 일치성을 검증합니다. JSON 직렬화 결과에 Changes지원 번들 검증
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change adds regression coverage for support-bundle runtime counts and secret exclusion without altering production behavior. No current merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
seonghobae
changed the title
seonghobae
added
maintenance
priority: medium
ChatGPT Codex Connector
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head product diff. Coverage is a separate gate.
Changed files
src/lib.rs— Rust package behavior
Changed behavior
classDiagram
class AppState
class SocLlmConfig
class ClearfolioConfig
class seeded
class load
class with_kev_catalog_url
class with_max_body_size
class with_clearfolio
Changed API
AppStateSocLlmConfigClearfolioConfigseededloadwith_kev_catalog_urlwith_max_body_sizewith_clearfoliowith_soc_llmwith_rate_limitwith_admin_tokenswith_credentials_sourceAppConfigmemorySupportBundleHealthStatusbuild_appexport_events_ndjsonupstream_targetAdminPrincipalparse_admin_tokensparse_event_limitparse_u32_envparse_u64_envrun_from_env
Findings
No source-backed product finding is synthesized from the coverage gate. A coverage miss belongs in the status comment.
- Head SHA:
ce58b6ec2968f314ea223ddb9ff7228fc4222e44 - Workflow run: 34170689654
- Workflow attempt: 1
- Coverage gate:
failure
Review outcome
Coverage is a gate, not the review. This body reviews the changed product files.
Changed-File Evidence Map
classDiagram
class AppState
class SocLlmConfig
class ClearfolioConfig
class seeded
class load
class with_kev_catalog_url
class with_max_body_size
class with_clearfolio
OpenCode Review Overview
Coverage evidence did not pass, so approval is blocked. The formal pull-request review is the source-backed diff review, not this status comment. |
2 participants
Problem
Protected
mainalready carries the shutdown-listener race repair, so the unique delta on this branch is the support-bundle regression contract.Current exact delta
This is a test-only hardening slice in
src/lib.rs; it does not change production runtime behavior.Fresh protected-main adoption — 2026-09-08 KST
Protected/default
mainadvanced from the branch's prior adopted base5829a0f08d78de464dd24393ce5d0f25fba9d126through merged #171 to exacta52ccd0a24a727d9349bb32def7713882d8cad1e. Fresh compare of predecessor head4db75680dcfa03d0592c62f08278fdef09c33694against current protected main proved the only effective product delta remainedsrc/lib.rs(+38/-0); the intervening protected-only change is #171's ADR documentation and does not overlap this test slice.The branch therefore adopted exact protected main non-destructively with two-parent merge commit
ce58b6ec2968f314ea223ddb9ff7228fc4222e44, preserving predecessor4db75680...as first parent and protecteda52ccd0...as second parent. The merge tree is exact protected-main tree plus the previously reviewedsrc/lib.rsblob; no force push, destructive rebase, broad source reconstruction, or foreign-owner delta was introduced.Fresh post-adoption compare is
behind_by=0, merge base exactlya52ccd0..., and the complete protected-main-relative delta is still exactly 38 added test lines insrc/lib.rs.Exact-current evidence
Current exact head is
ce58b6ec2968f314ea223ddb9ff7228fc4222e44. All predecessor workflow/review conclusions are historical after the real ancestry movement and do not transfer.34169323244— SUCCESS;34169323221— SUCCESS;34169323227— SUCCESS;34169323232— SUCCESS;34169323205— FAILURE at the central delegated terminal-receipt boundary, not a Wardnet support-bundle test/source finding.This unchanged head remains a consumer specimen for canonical central owner issue
.github#1929. The active central repair is.github#1902; because that owner branch is mutable until protected, this PR deliberately does not pin a stale owner head or treat it as a dependency. Re-read the live central head/checks before any integration decision. Wardnet does not source-churn this clean head or synthesize a delegated verdict.Live organization ruleset
18156473still requires one generic approval with no named/code-owner/last-push reviewer and exposesOrganizationAdmin/alwaysbypass..github#772owns the solo-maintainer governance repair. Self/model approval and routine administrator bypass remain forbidden.Ready metadata is review admission, not merge authorization. Merge only on one unchanged exact current head through the ordinary protected path after all then-live deterministic/security/coverage/package/SBOM/provenance/review/thread/governance requirements are terminal-valid and protected-base compatibility remains fresh. No gate weakening, force push, destructive rebase, mutable foreign dependency, source copy, cross-service SQL, or predecessor-evidence transfer.